[IMP] Charts: keep and disable useless dataseries for pyramid chart #5782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
anhe-odoo
force-pushed
the
master-chart-keep_and_disabled_useless_dataseries-anhe
branch
2 times, most recently
from
d3539fe to
c963e50
Compare
hokolomopo
reviewed
Feb 27, 2025
Comment on lines
146
to
148
| nextProps.enabled?.join() !== this.props.enabled?.join() && | ||
| nextProps.enabled?.join() !== this.store.enabled.join() |
There was a problem hiding this comment.
Got a stacktrace with deepEquals when running the tests :/
anhe-odoo
force-pushed
the
master-chart-keep_and_disabled_useless_dataseries-anhe
branch
2 times, most recently
from
7c0c0a7 to
b19ddd8
Compare
hokolomopo
reviewed
Mar 7, 2025
src/components/side_panel/chart/building_blocks/data_series/data_series.ts
Outdated
Show resolved
Hide resolved
src/components/side_panel/chart/geo_chart_panel/geo_chart_config_panel.ts
Outdated
Show resolved
Hide resolved
anhe-odoo
force-pushed
the
master-chart-keep_and_disabled_useless_dataseries-anhe
branch
from
b19ddd8 to
04c9172
Compare
hokolomopo
reviewed
Mar 11, 2025
There was a problem hiding this comment.
Functional question: should be we able to edit the unused ranges ? ATM when adding a third range to a pyramid, we can edit the input, then after pressing confirm it's impossible to edit the range value. And when editing the selection input, the disabled ranges are not colored, but still have colored highlights in the grid.
I don't have strong feelings on this, I think it's fine as it, but it probably deserves a discussion with a "po".
src/components/side_panel/chart/pyramid_chart/pyramid_chart_config_panel.xml
Outdated
Show resolved
Hide resolved
src/components/side_panel/chart/pyramid_chart/pyramid_chart_config_panel.ts
Outdated
Show resolved
Hide resolved
src/components/side_panel/chart/building_blocks/generic_side_panel/config_panel.ts
Outdated
Show resolved
Hide resolved
anhe-odoo
force-pushed
the
master-chart-keep_and_disabled_useless_dataseries-anhe
branch
from
04c9172 to
bf41eaf
Compare
hokolomopo
reviewed
Mar 17, 2025
| @@ -25,11 +29,13 @@ | |||
| t-on-keydown="onKeydown" | |||
| t-att-value="range.xc" | |||
| t-att-style="getColor(range)" | |||
| t-att-title="range.disabled ? props.disabledTitle : ''" | |||
There was a problem hiding this comment.
Suggested change
| t-att-title="range.disabled ? props.disabledTitle : ''" | |
| t-att-title="range.disabled ? props.disabledTitle : undefined" |
nitpick. I think this avoids having empty title in the HTML and having to change the snapshots
| @@ -47,6 +50,8 @@ interface Props { | |||
| onSelectionRemoved?: (index: number) => void; | |||
| onSelectionConfirmed?: () => void; | |||
| colors?: Color[]; | |||
| disabledRanges?: boolean[]; | |||
| disabledTitle?: string; | |||
There was a problem hiding this comment.
Suggested change
| disabledTitle?: string; | |
| disabledRangeTitle?: string; |
nitpick. Probably a bit better ?
Task Description Currently, when creating a pyramid chart with more than two data series, we are removing the unused ones, which lead to a loss of data series when switching back to another chart type. This PR aims to change this behavior, by keeping all the data series but keeping only the first two in the runtime, and showing the redundant series as disabled in the config panel. Related Task Task: 4570622
anhe-odoo
force-pushed
the
master-chart-keep_and_disabled_useless_dataseries-anhe
branch
from
bf41eaf to
46972d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Description
Currently, when creating a pyramid chart with more than two data series, we are removing the unused ones, which lead to a loss of data series when switching back to another chart type.
This PR aims to change this behavior, by keeping all the data series but keeping only the first two in the runtime, and showing the redondant series as disabled in the config panel.
Related Task
review checklist