Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] composer: async auto-complete #5799

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[IMP] composer: async auto-complete #5799

wants to merge 2 commits into from

Conversation

LucasLefevre
Copy link
Collaborator

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Feb 25, 2025

Pull request status dashboard

@LucasLefevre LucasLefevre force-pushed the master-list-relations-auto-complete-lul branch 6 times, most recently from 31f8c16 to 8f6d296 Compare February 25, 2025 17:00
@LucasLefevre
[REF] composer: move autocomplete state to store
8095dfd 
This commit prepares the ground for async auto-complete.
With async, the state needs to be updated after the promise resolves.
However, the state is currently not co-located with the business logic.
The state lives in the composer component while the logic lives in the
store.

With this commit, everything is moved to the store. It will allow to easily
update the state when the async promise resolves since it'll be directly
available.

Task: 3704595
@LucasLefevre
[IMP] composer: async auto-complete
3c0e455 
Task: 3704595
@LucasLefevre LucasLefevre force-pushed the master-list-relations-auto-complete-lul branch from 8f6d296 to 3c0e455 Compare March 4, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasLefevre @robodoo