[FIX] Config: check stylesheets scope #5836
Conversation
|
|
rrahir
force-pushed
the
saas-18.2-enforce-spreadsheet-scope-scss-rar
branch
from
71c2087 to
22063a1
Compare
| then | ||
| exit 0; #THE USER WANTS TO CONTINUE | ||
| else | ||
| if [ $? -ne 0 ]; then |
rrahir
force-pushed
the
saas-18.2-enforce-spreadsheet-scope-scss-rar
branch
from
22063a1 to
e92ace9
Compare
.husky/pre-commit
Outdated
| scssregexp='.*\.scss' | ||
| ignoreFileInstruction='\/\* husky-ignore \*\/' | ||
| filelist=() | ||
| for file in $(git diff --cached --name-only | grep -E $scssregexp); do |
There was a problem hiding this comment.
check is not enought :x This is not flagged as invalid css
There was a problem hiding this comment.
I know, we discussed this limitation yesterday. it's more about having a generic check so the dev stays alert rather than having a full parser just for the fun.. or else I need to make a js script because standard grep is not smart enough to get it done but it seemed not necessary. @LucasLefevre
edit: punctuation re-edit: typos
There was a problem hiding this comment.
Grep can probably still do the job in this case I think. We could maybe have a regex (startOfLine)(somethingThatIsn't.o-spreadshhet) Will only work is the CSS is correctly prettified but w/e.
This should work ?
^(\.(?!o-spreadsheet)|[a-zA-Z]+).*\{
There was a problem hiding this comment.
you need to handle multi line grep which does not work on macos for instance, so no it does not work.
There was a problem hiding this comment.
i'll try to do a correct js script whenever I have the time
rrahir
force-pushed
the
saas-18.2-enforce-spreadsheet-scope-scss-rar
branch
3 times, most recently
from
ecf51c2 to
d707d0a
Compare
The style that we define in our component can sometimes interfere within Odoo. This revision adds a step to force the style to be scoped to 'o-spreadsheet'. Task: 4629441
rrahir
force-pushed
the
saas-18.2-enforce-spreadsheet-scope-scss-rar
branch
from
d707d0a to
7352ddc
Compare
The style that we define in our component can sometimes interfere within Odoo. This revision adds a step to force the style to be scoped to 'o-spreadsheet'.
Task: 4629441
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist