Master odoo funnel chart adrm #5838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The conversion `ExcelChartDefinition` -> `ChartDefinition` was not correct. We created a chart definition with an arbitrary type, and with properties that are not always in the `ChartDefinition` for this type (eg. `labelsAsText` for bar chart). The correct way to handle that is to create a `ChartCreationContext`, and create a definition from it. I'm really not sure why the typing wasn't catching the issue. Note: also fixed an issue with a circular dependency, `translation_terms.ts` no longer import `paste_interactive.ts`. Task: 4626404
hokolomopo
force-pushed
the
master-odoo-funnel-chart-adrm
branch
from
8afe6e1 to
88f9353
Compare
This commit makes it so our ChartJS extensions work even if the chartJS library was reloaded between the moment where we loaded the `o_spreadsheet` library and the moment where we actually use the extensions. Task: 4627232
This commit adds the cumulative option to the funnel chart. There is a slight difference from the cumulative option in the line chart. For line chart, the first value stay the same and is added to the next. For funnel it's the inverse, the last value stay the same and is added to the previous (the top of the funnel grows, not the bottom). Task: 4626404
Task: 4629660
hokolomopo
force-pushed
the
master-odoo-funnel-chart-adrm
branch
from
88f9353 to
90923ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMP] chart: export funnel chart side panel
Task: 4629660
review checklist