[IMP] Selection: convert grid drag-n-drop into a hook #5919
+284
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rrahir
commented
Mar 17, 2025
|
|
||
| const cleanUp = () => { | ||
| cleanUpFns.forEach((fn) => fn()); | ||
| cleanUpFns = [() => clearTimeout(timeOutId), () => (timeOutId = null)]; |
There was a problem hiding this comment.
we coul call it by hand and not repush each time
|
Missing a test with the improved behaviour that clears up the event listeners once the caller was unmounted |
hokolomopo
reviewed
Mar 18, 2025
|
|
||
| let cleanUpFns: (() => void)[] = [() => clearTimeout(timeOutId), () => (timeOutId = null)]; | ||
|
|
||
| const cleanUp = () => { |
There was a problem hiding this comment.
Is it possible to test that the callbacks are cleanup on unmount now ?
rrahir
force-pushed
the
master-grid-dnd-hook-rar
branch
3 times, most recently
from
6fd6118 to
fbdd6cd
Compare
rrahir
force-pushed
the
master-grid-dnd-hook-rar
branch
from
fbdd6cd to
c58da86
Compare
Task: 3582335
rrahir
force-pushed
the
master-grid-dnd-hook-rar
branch
from
c58da86 to
756e549
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: 3582335
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist