[IMP] menu: more positioning options for Menu component
#5947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The `Menu` component was taking a `{x,y}` props for its positioning.
This is not enough to cover that cases when we want the menu to be
positioned around a rectangle when there is not enough space for the
menu to be displayed at the bottom left.
With this commit:
- the menu of `SelectMenu` is does not overlap anymore with the select
when the menu is displayed upwards
- the menu of `Figure` is positioned right of the figure, and only flip
to the left if there is not enough space
- the menu of `LinkEditor` is positioned right of the menu button, and
not to a random position
Task: 4655815
hokolomopo
force-pushed
the
master-menu-position-adrm
branch
from
24a9e1e to
26b1fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Menucomponent was taking a{x,y}props for its positioning. This is not enough to cover that cases when we want the menu to be positioned around a rectangle when there is not enough space for the menu to be displayed at the bottom left.With this commit:
SelectMenuis does not overlap anymore with the select when the menu is displayed upwardsFigureis positioned right of the figure, and only flip to the left if there is not enough spaceLinkEditoris positioned right of the menu button, and not to a random positionTask: TODO
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist