Skip to content

[IMP] menu: more positioning options for Menu component #5947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hokolomopo
Copy link
Contributor

@hokolomopo hokolomopo commented Mar 18, 2025

The Menu component was taking a {x,y} props for its positioning.
This is not enough to cover that cases when we want the menu to be
positioned around a rectangle when there is not enough space for the
menu to be displayed at the bottom left.

With this commit:

  • the menu of SelectMenu no longer overlap with the select
    when the menu is displayed upwards
  • the menu of Figure is positioned to the right of the figure and only flip
    to the left if there is not enough space
  • the menu of LinkEditor is positioned to the right of the menu button instead of a random position

Task: 4655815

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Mar 18, 2025

Pull request status dashboard

@hokolomopo hokolomopo force-pushed the master-menu-position-adrm branch from 24a9e1e to 26b1fcc Compare March 18, 2025 13:11
Copy link
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was some typos in the commit message, here is a suggestion:

The `Menu` component was taking a `{x,y}` props for its positioning.
This is not enough to cover that cases when we want the menu to be
positioned around a rectangle when there is not enough space for the
menu to be displayed at the bottom left.

With this commit:
- the menu of `SelectMenu` no longer overlap with the select
   when the menu is displayed upwards
- the menu of `Figure` is positioned to the right of the figure and only flip
    to the left if there is not enough space
- the menu of `LinkEditor` is positioned to the right of the menu button instead of a random position

Task: 4655815

The `Menu` component was taking a `{x,y}` props for its positioning.
This is not enough to cover that cases when we want the menu to be
positioned around a rectangle when there is not enough space for the
menu to be displayed at the bottom left.

With this commit:
- the menu of `SelectMenu` no longer overlap with the select
   when the menu is displayed upwards
- the menu of `Figure` is positioned to the right of the figure and only
    flip to the left if there is not enough space
- the menu of `LinkEditor` is positioned to the right of the menu
    button instead of a random position

Task: 4655815
@hokolomopo hokolomopo force-pushed the master-menu-position-adrm branch from 26b1fcc to c65ad3a Compare March 28, 2025 08:54
@rrahir
Copy link
Collaborator

rrahir commented Mar 31, 2025

@robodoo r+

robodoo pushed a commit that referenced this pull request Mar 31, 2025
The `Menu` component was taking a `{x,y}` props for its positioning.
This is not enough to cover that cases when we want the menu to be
positioned around a rectangle when there is not enough space for the
menu to be displayed at the bottom left.

With this commit:
- the menu of `SelectMenu` no longer overlap with the select
   when the menu is displayed upwards
- the menu of `Figure` is positioned to the right of the figure and only
    flip to the left if there is not enough space
- the menu of `LinkEditor` is positioned to the right of the menu
    button instead of a random position

closes #5947

Task: 4655815
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo added the 18.3 label Mar 31, 2025
@robodoo robodoo closed this Mar 31, 2025
@fw-bot fw-bot deleted the master-menu-position-adrm branch April 7, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants