Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] composer: prevent autocomplete on unknown characters in composer #5986

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rachico
Copy link
Contributor

@Rachico Rachico commented Mar 20, 2025

Before this commit, the composer incorrectly triggered autocomplete suggestions even when unknown or special characters (e.g., "é") were typed. This led to irrelevant suggestions and formula errors when selecting an option.

This commit ensures that unknown characters are properly considered, preventing autocomplete from being triggered in such cases, improving the reliability of the function autocomplete.

Task: 4652661

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Before this commit, the composer incorrectly triggered autocomplete suggestions
even when unknown or special characters (e.g., "é") were typed. This led to irrelevant
suggestions and formula errors when selecting an option.

This commit ensures that unknown characters are properly considered, preventing autocomplete
from being triggered in such cases, improving the reliability of the function autocomplete.

task: 4652661
@robodoo
Copy link
Collaborator

robodoo commented Mar 20, 2025

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants