[IMP] color-picker: remove additional # #6104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fdamhaut
force-pushed
the
17.0-color-picker-paste-hex-flda
branch
from
237422d to
7d360c6
Compare
hokolomopo
reviewed
Apr 15, 2025
| @@ -366,7 +366,7 @@ export class ColorPicker extends Component<ColorPickerProps, SpreadsheetChildEnv | |||
|
|
|||
| setHexColor(ev: InputEvent) { | |||
| // only support HEX code input | |||
| const val = (ev.target as HTMLInputElement).value.slice(0, 7); | |||
| const val = "#" + (ev.target as HTMLInputElement).value.replaceAll("#", "").slice(0, 6); | |||
There was a problem hiding this comment.
when pasting "fff#abc" (something that is clearly not valid), it becomes #fffabc. Maybe we don't care. Or maybe you could just replace double #. Your pick 🤷
There was a problem hiding this comment.
🤔 If i copy #fff after #000, it would end up in #000fff, which is maybe a wrong behaviour ?
I'll change to replacing #* to #
How to reproduce
Copy a color code (i.e. #E6F2F3)
Create a custom table
Edit its color using the color picker
Double-click the current code and replace it by #E6F2F3
As the double-click doesn't grab the #, you get ##E6F2F
Task: 4687930
fdamhaut
force-pushed
the
17.0-color-picker-paste-hex-flda
branch
from
7d360c6 to
28c90c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce
Copy a color code (i.e. #E6F2F3)
Create a custom table
Edit its color using the color picker
Double-click the current code and replace it by #E6F2F3
As the double-click doesn't grab the #, you get ##E6F2F
Task: 4687930
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 4687930
review checklist