Skip to content

[IMP] carousel: export in xlsx #7055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[IMP] carousel: export in xlsx #7055

wants to merge 3 commits into from

Conversation

hokolomopo
Copy link
Contributor

wip

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@hokolomopo
[IMP] model: improve figure export data
c955dc4 
Currently, charts/images/carousels are exported inside `figure.data`
in the JSON. That's not ideal, `figure.data` then needs to be typed as
`any`, and the charts plugin need to be aware of carousels for its
import.

This commit changes the export, now each plugin has its own key in the
data, so it can be typed correctly and they are not interlinked.

Task: 5002886
@robodoo
Copy link
Collaborator

robodoo commented Sep 3, 2025

Pull request status dashboard

@hokolomopo hokolomopo changed the title [IMP] model: improve figure export data [IMP] carousel: export in xlsx Sep 3, 2025
@hokolomopo
[FIX] tests: xlsx fix image ids at export
a6d5d89 
The conversion imageId <=> xlsx image id was done with a global variable
which was not reset between tests, leading to test giving different
result when running the whole file or a single test.

Task: 5056097
@hokolomopo
[IMP] carousel: add xlsx export
e19e23e 
This commit adds the export of carousel to the xlsx. As Excel does not
support carousels, we import each chart of the carousel individually
into separate figures.

Task: 5056097
@hokolomopo hokolomopo force-pushed the master-carousel-xlsx-export-adrm branch from b9379c0 to e19e23e Compare September 4, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hokolomopo @robodoo