[FIX] header_size: wrong row size from wrapped number #7527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
If a literal cell containing a number was wrapped (because the number was large, or because it had a long format), the row height was wrong. Task: 4878338
hokolomopo
force-pushed
the
17.0-fix-numbre-wrapping-adrm
branch
from
ed90cda to
123dbc2
Compare
rrahir
reviewed
Dec 5, 2025
| content = formatValue(parseLiteral(cell.content, locale), localeFormat); | ||
| } | ||
| } catch { | ||
| content = CellErrorType.GenericError; |
Collaborator
There was a problem hiding this comment.
can this fail for other reasons than an invalid format?
and is it possible in real life conditions to have an invalid format?
Contributor
Author
There was a problem hiding this comment.
Yeah only for invalid formats. I don't think it should happens in practice, but we do have a test with invalid format that fails without the try/catch so ... (Update cell with a format is correctly set)
Collaborator
There was a problem hiding this comment.
we should discuss the possibility/necessity to reject invalid formats then ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a literal cell containing a number was wrapped (because the number was large, or because it had a long format), the row height was wrong.
Task: 4878338
review checklist