[FIX] charts: small zoom is disabled #7576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Collaborator
Author
|
@anhe-odoo @pro-odoo cherrypicking of pull request #7069 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Collaborator
Author
|
@anhe-odoo @pro-odoo this forward port of #7069 is awaiting action (not merged or closed). |
anhe-odoo
force-pushed
the
master-master-chart-fix-timeline_empty_chart-anhe-460962-fw
branch
from
42e8c1f to
660b149
Compare
Task Description: This task aims to reduce issue coming from the zoom feature in two cases : 1. Make the slider looks "disabled" when there is only one data point 2. Don't zoom when the new min and max value are equals 3. The onMouseUp event is now resetting the displayed boundaries according to the chart boundaries, to stay consistant. Among all the changes, a new behavior has been added for the onMouseUp in the master chart, where the lowerBound and the upperBound are updated according to the real displayed boundaries of the detail chart computed by chartJs. This avoid having lots of different cases to recompute the boundaries one last time according to the type of chart and axis. Unfortunately, two tests are now unusable (checking the rounding of the boundaries when mouseUping) as chartJs is not fully used/mocked in the test, and then the boundaries are not correctly recomputed. Related task Task: 5058567 X-original-commit: 2916089
anhe-odoo
force-pushed
the
master-master-chart-fix-timeline_empty_chart-anhe-460962-fw
branch
from
660b149 to
3d104ef
Compare
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 9, 2025
Task Description: This task aims to reduce issue coming from the zoom feature in two cases : 1. Make the slider looks "disabled" when there is only one data point 2. Don't zoom when the new min and max value are equals 3. The onMouseUp event is now resetting the displayed boundaries according to the chart boundaries, to stay consistant. Among all the changes, a new behavior has been added for the onMouseUp in the master chart, where the lowerBound and the upperBound are updated according to the real displayed boundaries of the detail chart computed by chartJs. This avoid having lots of different cases to recompute the boundaries one last time according to the type of chart and axis. Unfortunately, two tests are now unusable (checking the rounding of the boundaries when mouseUping) as chartJs is not fully used/mocked in the test, and then the boundaries are not correctly recomputed. Related task closes #7576 Task: 5058567 X-original-commit: 2916089 Signed-off-by: Pierre Rousseau (pro) <[email protected]> Signed-off-by: Hendrickx Anthony (anhe) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Description:
This task aims to reduce issue coming from the zoom feature in two cases :
Related task
Forward-Port-Of: #7069