Skip to content

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Dec 9, 2025

Description

In the side panel, the preview of a conditional formatting rule is truncated at 142px, even if there is enough space to display it fully.

Task: 5344000

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #7615
Forward-Port-Of: #7492

@robodoo
Copy link
Collaborator

robodoo commented Dec 9, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Dec 9, 2025

@hokolomopo @rrahir cherrypicking of pull request #7492 failed.

stdout:

Auto-merging src/components/side_panel/conditional_formatting/cf_preview/cf_preview.ts
CONFLICT (content): Merge conflict in src/components/side_panel/conditional_formatting/cf_preview/cf_preview.ts
Auto-merging src/components/side_panel/conditional_formatting/cf_preview/cf_preview.xml
CONFLICT (content): Merge conflict in src/components/side_panel/conditional_formatting/cf_preview/cf_preview.xml
Auto-merging tests/conditional_formatting/__snapshots__/conditional_formatting_panel_component.test.ts.snap
CONFLICT (content): Merge conflict in tests/conditional_formatting/__snapshots__/conditional_formatting_panel_component.test.ts.snap

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

In the side panel, the preview of a conditional formatting rule is
truncated at 142px, even if there is enough space to display it fully.

Task: 5344000
X-original-commit: 86b6138
@hokolomopo hokolomopo force-pushed the master-17.0-cf-preview-truncated-adrm-483078-fw branch from dc62d17 to 5f07142 Compare December 12, 2025 08:15
@hokolomopo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Dec 12, 2025
In the side panel, the preview of a conditional formatting rule is
truncated at 142px, even if there is enough space to display it fully.

closes #7617

Task: 5344000
X-original-commit: 86b6138
Signed-off-by: Rémi Rahir (rar) <[email protected]>
Signed-off-by: Adrien Minne (adrm) <[email protected]>
@robodoo robodoo added the 19.1 label Dec 12, 2025
@robodoo robodoo closed this Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants