[FIX] CorePlugins: Prevent dispatch during adaptRange #7632
+87
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

The method
adaptRangewas originally designed for each plugin to update their own ranges, whithout having to manually react to the different commands that alter the sheets structure.We have abused the system when we introduced the spreadsheet pivots to allow the modification of a pivot dataset (which is stored in PivotCorePlugin) from another entry point
SpreadsheetPivotCorePlugin) by dispatching an UPDATE_PIVOT command but there are some side effects that we did not account for, the dispatched command is forwarded to EVERY other plugin. Meaning that during an adaptRange, which should only concern a specific plugin, we end up notifying a change to the whole core/coreview stack.This revision removes the access to 'dispatch' during the handling of
adaptRangeso we ensure that the changes are kept locally.Task: 5380747
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist
Forward-Port-Of: #7630
Forward-Port-Of: #7603