Some misc and fixes related to the border-collapse+box-sizing+layout fixes future PR #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR contains miscellaneous fixes and improvements to table layout handling in preparation for future border-collapse and box-sizing fixes. It restructures table test markup and improves code organization in the table layout implementation.
- Refactors table test markup to use proper div elements instead of self-closing tags
- Extracts paint-related border and outline building functions for better modularity
- Improves table layout code organization with renamed helper structures and exposed utility functions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/css/display-table.xhtml | Restructures table cell markup to use proper div elements with closing tags and adds new padding resolution test |
| src/vaev-engine/layout/table.cpp | Improves code organization by renaming helper structures and fixing table cell layout context |
| src/vaev-engine/layout/paint.cpp | Extracts border and outline building logic into standalone functions for better modularity |
| src/vaev-engine/layout/layout.cpp | Exposes previously private utility functions for broader use across the codebase |
| src/vaev-engine/layout/layout-impl.cpp | Updates function calls to use newly exposed public functions |
sleepy-monax
requested changes
Sep 9, 2025
…g correct padding resolution.
pauloamed
force-pushed
the
palm/misc-n-fixes-1
branch
from
f7cb123 to
6781dd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.