[IMP] runbot: refactor build error models #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavier-Do
force-pushed
the
17.0-next-build-error-model-xdo
branch
6 times, most recently
from
e7f0bd0 to
b1722e8
Compare
d-fence
requested changes
Nov 6, 2024
| build_count = 0 | ||
| first_seen_build_id = first_seen_date = last_seen_build_id = last_seen_date = None | ||
| if error_id in vals_by_error: | ||
| error_vals = [vals_by_error[error_id] for error_id in all_errors] |
There was a problem hiding this comment.
Suggested change
| error_vals = [vals_by_error[error_id] for error_id in all_errors] | |
| error_vals = [vals_by_error[error_id] for error_id in all_errors if error_id in vals_by_error] |
To avoid script failure when to the error has no build linked.
The initial idea to link an error to another one was a quick solution to group them if they where related, but this became challenging to copute metada regarding errors. - The displayed error message was not always consistent with the real root cause/the error that lead here. - The aggregates (lets says, linked buils ids) could be the one of the error, or from all error messages. Same for the versions, first seen, .. This is confusing to knwo what is the leist we are managing and what is the expecte result to display Main motivation: on a standard error page (will be changed to "assignment"), we want to have the list of error message that is related to this one. We want to know for each message (a real build error) what is the version, first seen, ... This will give more flexibility on the display, The assigned person/team/test-tags, ... are moved to this model The appearance data remains on the build error but are aggregate on the assignation.
Fix a failure when a build error is not linked to any build. It happens when a build error was merged into another.
d-fence
force-pushed
the
17.0-next-build-error-model-xdo
branch
from
7bb9a8d to
e3602e5
Compare
d-fence
force-pushed
the
17.0-next-build-error-model-xdo
branch
from
2fa1203 to
6beede9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial idea to link an error to another one was a quick solution to group them if they where related, but this became challenging to compute metada regarding errors.
This is confusing to knwo what is the leist we are managing and what is the expecte result to display
Main motivation:
on a standard error page (will be changed to "assignment"), we want to have the list of error message that is related to this one. We want to know for each message (a real build error) what is the version, first seen, ...
This will give more flexibility on the display,
The assigned person/team/test-tags, ... are moved to this model
The appearance data remains on the build error but are aggregate on the assignation.