ngtpn - Technical Training #1024
Open
+671
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nguyenntph
force-pushed
the
19.0-training-ngtpn
branch
from
fab7cec to
be28ed8
Compare
nguyenntph
force-pushed
the
19.0-training-ngtpn
branch
from
88cf064 to
b57ec0f
Compare
nguyenntph
force-pushed
the
19.0-training-ngtpn
branch
from
b57ec0f to
263a6fb
Compare
nguyenntph
force-pushed
the
19.0-training-ngtpn
branch
from
263a6fb to
812c7c1
Compare
clbr-odoo
requested changes
Nov 19, 2025
Contributor
clbr-odoo
left a comment
clbr-odoo
left a comment
There was a problem hiding this comment.
Nice to see that you know of to rewrite your git history & force-push.
I advice to use the --force-with-lease option if you haven't, as a general security.
Very good job so far 👍
Props for the clean indentation of the Python file 🥳
nguyenntph
force-pushed
the
19.0-training-ngtpn
branch
from
645e23b to
5051e18
Compare
nguyenntph
force-pushed
the
19.0-training-ngtpn
branch
from
4b1005a to
9deb164
Compare
nguyenntph
force-pushed
the
19.0-training-ngtpn
branch
from
b081baf to
e23811d
Compare
- Inline views - Statusbar - Sort order - Field options - Readonly
nguyenntph
force-pushed
the
19.0-training-ngtpn
branch
from
6bcfded to
bbd5cbe
Compare
- Color picker - Editable list view - Decorators - Fix no create/edit - Add offer link - Add domain
nguyenntph
force-pushed
the
19.0-training-ngtpn
branch
from
bbd5cbe to
dae9bd4
Compare
nguyenntph
force-pushed
the
19.0-training-ngtpn
branch
from
60bfa6c to
47485cd
Compare
nguyenntph
force-pushed
the
19.0-training-ngtpn
branch
from
47485cd to
30a5051
Compare
yoba-odoo
requested changes
Nov 20, 2025
yoba-odoo
left a comment
yoba-odoo
left a comment
There was a problem hiding this comment.
Nice work 👏
Left some non-blocking comments
Comment on lines
48
to
65
| <group> | ||
| <field name="property_id"/> | ||
| </group> | ||
| <group> | ||
| <field name="partner_id"/> | ||
| </group> | ||
| <group> | ||
| <field name="price"/> | ||
| </group> | ||
| <group> | ||
| <field name="status"/> | ||
| </group> | ||
| <group> | ||
| <field name="validity" string="Validity (days)"/> | ||
| </group> | ||
| <group> | ||
| <field name="date_deadline" string="Deadline"/> | ||
| </group> |
There was a problem hiding this comment.
You don't have to put each field alone in a group. Am I missing something?
Author
There was a problem hiding this comment.
Seems like we don't. This is the code block we used as example in Chapter 6, using group for each fields.
I tried having the fields in 1 group and everything works fine.
- Model description - Error messages - Views group - Default data type - Simplify conditional check
nguyenntph
force-pushed
the
19.0-training-ngtpn
branch
from
88d0079 to
02624c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.