[ADD] estate: init commit for estate module #1027

ybenbrai · 2025-11-18T12:46:14Z

No description provided.

robodoo · 2025-11-18T12:46:17Z

clbr-odoo

Good job so far, just a few comments !

Your commit title are not fully correct: usually we put the [ADD] tag on the module init (where the manifest is). Following commits will be [IMP](provements) to the now existing module.
See git guidelines for more details.

clbr-odoo · 2025-11-19T08:13:55Z

estate/security/ir.model.access.csv

This should be in a folder named security by convention, not data.

clbr-odoo · 2025-11-19T08:18:39Z

estate/models/estate_property.py

+from odoo import fields, models
+
+
+class Property(models.Model):


Suggested change

class Property(models.Model):

class EstateProperty(models.Model):

There is no big incidence here but we generally put the name of the file in CamelCase here.
It's usually good to be specific. Property is super generic and could be existing in other modules.

clbr-odoo · 2025-11-19T08:19:01Z

estate/models/estate_property.py

+
+class Property(models.Model):
+    _name = "estate.property"
+    _description = "This is a estate property"


Suggested change

_description = "This is a estate property"

_description = "Estate property"

clbr-odoo · 2025-11-19T08:20:20Z

estate/models/estate_property.py

+class Property(models.Model):
+    _name = "estate.property"
+    _description = "This is a estate property"
+    _order = "sequence"


That _order will define how the search will return you the records.
You don't have a sequence field on your estate.property model, leave it empty to keep the default (that order by ID) for now.

clbr-odoo · 2025-11-19T08:21:39Z

estate/models/estate_property.py

+    _description = "This is a estate property"
+    _order = "sequence"
+
+    name = fields.Char('Name', required=True)


Suggested change

name = fields.Char('Name', required=True)

name = fields.Char(string='Name', required=True)

Note that what you did is totally equivalent to this ☝️ . Some reviewers prefer that we name all parameters explicitly.
Also note that by default, Odoo will use the variable name to create a label if not provided.
In this case it will create "Name", so you don't really need to specify it.

Note that what you did is totally equivalent to this ☝️ . Some reviewers prefer that we name all parameters explicitly. Also note that by default, Odoo will use the variable name to create a label if not provided. In this case it will create "Name", so you don't really need to specify it.

okay noted !, i changed it to Title in local now to match the screenshots

clbr-odoo · 2025-11-19T08:32:02Z

estate/view/__init__.py

You don't need to have an __init__ file in your view folder as it does not contain Python files.

By convention, that folder should not be view but views. Please double-check the coding guidelines for reference. Also don't hesitate to start to explore Odoo codebase and copy how it's done 🙂

clbr-odoo · 2025-11-19T08:32:15Z

estate/view/estate_property_views.xml

+              action="estate_property_action" 
+              parent="estate_menu_advertisements"/>
+
+</odoo>


Missing EOL at the end of the file.

clbr-odoo · 2025-11-19T08:32:39Z

estate/__manifest__.py

+         'data/ir.model.access.csv',
+         'view/estate_property_views.xml',


Suggested change

'data/ir.model.access.csv',

'view/estate_property_views.xml',

'security/ir.model.access.csv',

'views/estate_property_views.xml',

clbr-odoo · 2025-11-19T08:33:38Z

estate/__manifest__.py

+    'summary': 'Track Real Estate',
+    'website': 'https://www.odoo.com/app/realestate',
+    'author': 'Odoo S.A.',
+    'license': 'LGPL-3',


Suggested change

'license': 'LGPL-3',

'application': True,

'license': 'LGPL-3',

You probably want to have application=True for this module. See the manifest reference.

clbr-odoo · 2025-11-19T08:35:49Z

estate/view/estate_property_views.xml

+        <field name="view_mode">tree,form</field>
+    </record>
+
+    <menuitem id="estate_menu_root" name="Real Estate"/>


Note that you can also nest the module to avoid defining the parent, like this:

<menuitem ...> <menuitem .../> </menuitem/>

added more fields to the database table with needed requirements

added access rights

fixed the issues on linting

actions menu view

added improvement to the properties

added search / filter / form / header

fixed the issue for the styles and the tutorial syntax

added tags types.. and accesses and infos in the form

Chapter 8: Computed Fields And Onchanges count the oriontation depend of criteria using action

added requirement of chapter 9

clbr-odoo

Don't forget to fix all missing EOL, keep up 👍

clbr-odoo · 2025-11-21T15:07:55Z

estate/security/ir.model.access.csv

+access_estate_property,access.estate.property,model_estate_property,base.group_user,1,1,1,1
+access_estate_property_type,access.estate.property.type,model_estate_property_type,base.group_user,1,1,1,1
+access_estate_property_tag,access.estate.property.tag,model_estate_property_tag,base.group_user,1,1,1,1
+access_estate_property_offer,access.estate.property.offer,model_estate_property_offer,base.group_user,1,1,1,1


EOL missing at the end of the file.

clbr-odoo · 2025-11-21T15:08:01Z

estate/views/estate_list.xml

+            </list>
+        </field>
+    </record>
+</odoo>


clbr-odoo · 2025-11-21T15:08:06Z

estate/views/estate_menus.xml

+            <menuitem id="estate_property_tag_menu_action" name="Property Tags" action="estate_property_tag_action" />
+        </menuitem>
+    </menuitem>
+</odoo>


clbr-odoo · 2025-11-21T15:08:11Z

estate/views/estate_property_form_views.xml

+        <field name="res_model">estate.property.offer</field>
+        <field name="view_mode">tree,form</field>
+    </record>
+    </odoo>


clbr-odoo · 2025-11-21T15:08:17Z

estate/views/estate_property_tag_views.xml

+        <field name="view_mode">list,form</field>
+    </record>
+
+</odoo>


clbr-odoo · 2025-11-21T15:12:19Z

estate/models/estate_property.py

+    @api.depends('living_area', 'garden_area')
+    def _compute_total_area(self):
+        for rec in self:
+            rec.total_area = (rec.living_area or 0) + (rec.garden_area or 0)


This compute is defined twice (see line 76).

clbr-odoo · 2025-11-21T15:14:10Z

estate/models/estate_property.py

+            self.garden_orientation = False
+
+    def action_sold(self):
+        if "cancelled" in self.mapped("state"):


It works but it's not super readable. I'd do:

Suggested change

if "cancelled" in self.mapped("state"):

if any([prop.state == "cancelled" for prop in self]):

clbr-odoo · 2025-11-21T15:15:21Z

estate/models/estate_property.py

+    def action_sold(self):
+        if "cancelled" in self.mapped("state"):
+            raise UserError("Canceled property cannot be sold !")
+        return self.write({"state": "sold"})


Suggested change

return self.write({"state": "sold"})

self.state = 'sold'

return True

write doesn't return anything, and this notation also works, even if the recordset has many records.

clbr-odoo · 2025-11-21T15:15:42Z

estate/models/estate_property_offer.py

+    @api.depends('validity')
+    def _compute_date_deadline(self):
+        for offer in self:
+            if offer._origin.validity:


Suggested change

if offer._origin.validity:

if offer.validity:

validity will always be set, worst case to 0 so this if...else can be avoided.

clbr-odoo · 2025-11-21T15:18:01Z

estate/models/estate_property_offer.py

+            offer.property_id.selling_price = offer.price
+            offer.property_id.buyer_id = offer.partner_id.id
+            offer.property_id.state = 'offer_accepted'


Suggested change

offer.property_id.selling_price = offer.price

offer.property_id.buyer_id = offer.partner_id.id

offer.property_id.state = 'offer_accepted'

offer.property_id.write({

'selling_price': offer.price,

'buyer_id': offer.partner_id.id,

'state': 'offer_accepted',

})

It's better to do those three "write" in one :)

[ADD] estate: init commit for estate module

48b008c

tskv closed this Nov 18, 2025

tskv deleted the 19.0-tutorial-yoben branch November 18, 2025 13:06

tskv restored the 19.0-tutorial-yoben branch November 18, 2025 13:06

ybenbrai reopened this Nov 18, 2025

ybenbrai self-assigned this Nov 18, 2025

clbr-odoo reviewed Nov 19, 2025

View reviewed changes

youness benbraitit (yoben) added 5 commits November 19, 2025 10:30

[IMP] estate: database field creation

793dd90

added more fields to the database table with needed requirements

[IMP] estate: access rights

89f139a

added access rights

[IMP] estate: fixing linting issues

6e16ab7

fixed the issues on linting

[IMP] estate: Creating ui action

7de91aa

actions menu view

[IMP] estate: fix comments and apply suggestions

8a7f9f0

ybenbrai force-pushed the 19.0-tutorial-yoben branch from 06e1b31 to 8a7f9f0 Compare November 19, 2025 09:30

youness benbraitit (yoben) added 5 commits November 19, 2025 11:26

[IMP] estate: improvement to the state form

bad6fa4

added improvement to the properties

[IMP] estate: fixing styling issues

a6e8cf1

[IMP] adding features to the app

331420f

added search / filter / form / header

[FIX] estate: fix for ci checks

566aad6

fixed the issue for the styles and the tutorial syntax

[IMP] estate : Adding features to the estate app

a5cf231

added tags types.. and accesses and infos in the form

ybenbrai requested a review from clbr-odoo November 21, 2025 10:38

youness benbraitit (yoben) added 4 commits November 21, 2025 11:48

[IMP] estate: added feature to compute fields

a8c1bd4

Chapter 8: Computed Fields And Onchanges count the oriontation depend of criteria using action

[FIX] estate: fixed style issues

1b7200e

[IMP] estate: added accept/refuse offer

7758b15

added requirement of chapter 9

[FIX] Fixed ci style & tutorial issues

4f64cde

clbr-odoo reviewed Nov 21, 2025

View reviewed changes

		from odoo import fields, models


		class Property(models.Model):

	class Property(models.Model):
	class EstateProperty(models.Model):

	_description = "This is a estate property"
	_description = "Estate property"

	name = fields.Char('Name', required=True)
	name = fields.Char(string='Name', required=True)

		'data/ir.model.access.csv',
		'view/estate_property_views.xml',

	'license': 'LGPL-3',
	'application': True,
	'license': 'LGPL-3',

	if "cancelled" in self.mapped("state"):
	if any([prop.state == "cancelled" for prop in self]):

	return self.write({"state": "sold"})
	self.state = 'sold'
	return True

-            offer.property_id.selling_price = offer.price
-            offer.property_id.buyer_id = offer.partner_id.id
-            offer.property_id.state = 'offer_accepted'
+            offer.property_id.write({
+                'selling_price': offer.price,
+                'buyer_id': offer.partner_id.id,
+                'state': 'offer_accepted',
+            })

[ADD] estate: init commit for estate module #1027

Are you sure you want to change the base?

[ADD] estate: init commit for estate module #1027

Conversation

ybenbrai commented Nov 18, 2025

Uh oh!

robodoo commented Nov 18, 2025

Uh oh!

clbr-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

clbr-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants