[ADD] Estate: init #1034
Open
[ADD] Estate: init #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hazemayman1
force-pushed
the
19.0-tutorial_0-haabo
branch
from
6bac521 to
71b1ce0
Compare
clbr-odoo
requested changes
Nov 19, 2025
Contributor
clbr-odoo
left a comment
clbr-odoo
left a comment
There was a problem hiding this comment.
Very good job, keep up like that !
General comments:
- Take care to follow our git guidelines.Some of your commit don't respect it since they have an uppercase to the module name. The module name should be the "technical name" of the module, which is the folder name.
Example:
[FIX] Estate: CI compliance->[FIX] estate: CI compliance - Make sure you have enabled the removal of trailing spaces on save in your IDE. Note that I didn't see problems related to that in your PR. It's just a general advice. You can also consider setting it up to add a trailing EOL at the end of the files.
hazemayman1
force-pushed
the
19.0-tutorial_0-haabo
branch
from
b696008 to
a97811c
Compare
antonrom1
reviewed
Nov 20, 2025
antonrom1
left a comment
antonrom1
left a comment
There was a problem hiding this comment.
Mostly little style nitpicks but it looks great overall 🥳
| ("offer_received", "Offer Received"), | ||
| ("offer_accepted", "Offer Accepted"), | ||
| ("sold", "Sold"), | ||
| ("cancelled", "Cancelled"), |
There was a problem hiding this comment.
We usually use US english as default language. You can keep it here for the tutorial, just saying so you know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.