19.0 tutorials taskv #1035

tskv · 2025-11-18T14:24:13Z

No description provided.

robodoo · 2025-11-18T14:24:16Z

yoba-odoo

Impressive work 👏
Just some small nitpicks. Would also be great if we can squash the FIX commits to their parent IMP commits so we can have a clean commit history.

Keep up the good work 👌

yoba-odoo · 2025-11-19T13:51:53Z

estate/__manifest__.py

+    """,
+    'data': [
+        'security/ir.model.access.csv',
+


No need for this empty line

yoba-odoo · 2025-11-19T13:53:50Z

estate/models/estate_property.py

+    active = fields.Boolean('Active', default=True)
+    description = fields.Text('Description')
+    postcode = fields.Char('Postcode')
+    date_availability = fields.Date('Available From', copy=False, default=fields.Datetime.now() + timedelta(days=90))


Suggested change

date_availability = fields.Date('Available From', copy=False, default=fields.Datetime.now() + timedelta(days=90))

date_availability = fields.Date('Available From', copy=False, default=fields.Date.add(fields.Date.today(), months=3)

What you are doing is correct as well but we have a helper in odoo to do the same so it is better to use it

yoba-odoo · 2025-11-19T14:06:48Z

estate/views/estate_menus.xml

+        id="properties_menu"
+        name="Properties"
+        parent="estate_menu_root"
+        action="estate.estate_property_action"


Suggested change

action="estate.estate_property_action"

action="estate_property_action"

Since we are in the same folder as the action we don't have to use estate. to call the action it should be read automatically

yoba-odoo · 2025-11-19T14:07:03Z

estate/views/estate_menus.xml

+        id="properties_type_menu"
+        name="Property Types"
+        parent="settings_menu"
+        action="estate.estate_property_type_action"


Suggested change

action="estate.estate_property_type_action"

action="estate_property_type_action"

Same

yoba-odoo · 2025-11-19T14:07:19Z

estate/views/estate_menus.xml

+        id="properties_tag_menu"
+        name="Property Tags"
+        parent="settings_menu"
+        action="estate.estate_property_tag_action"


Suggested change

action="estate.estate_property_tag_action"

action="estate_property_tag_action"

Same

antonrom1

Good job! Mostly small comments. Keep it going like this for JS next week :P

antonrom1 · 2025-11-21T09:33:52Z

estate/__init__.py

+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+


The odoo license in every file is not needed anymore. You can remove it!

antonrom1 · 2025-11-21T09:38:17Z

estate/__manifest__.py

+    'demo': [
+    ],


you don't need to specify demo if it's empty

antonrom1 · 2025-11-21T09:39:54Z

estate/models/__init__.py

+from . import estate_property
+from . import estate_property_type
+from . import estate_property_tag
+from . import estate_property_offer
+from . import res_users


You just need to sort all imports by alphabetical order like here
https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#imports

antonrom1 · 2025-11-21T09:40:26Z

estate/models/__init__.py

+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+


Also you can remove that license, it's not needed anymore for any new odoo files

antonrom1 · 2025-11-21T09:46:29Z

estate/models/estate_property.py

+    garden_orientation = fields.Selection(string='Garden orientation',
+                                          selection=[('north', 'North'),
+                                                    ('south', 'South'),
+                                                    ('east', 'East'),
+                                                    ('west', 'West')]
+                                          )


This indentation is a little bit strange, I would do something like this

Suggested change

garden_orientation = fields.Selection(string='Garden orientation',

selection=[('north', 'North'),

('south', 'South'),

('east', 'East'),

('west', 'West')]

)

garden_orientation = fields.Selection(

string='Garden orientation',

selection=[

('north', 'North'),

('south', 'South'),

('east', 'East'),

('west', 'West'),

],

)

antonrom1 · 2025-11-21T16:15:23Z

estate/models/estate_property_offer.py

+            if 'property_id' in vals and vals.get('property_id'):
+                current_property = self.env['estate.property'].browse(vals['property_id'])
+                if 'price' in vals and current_property.best_offer > vals.get('price', 0):
+                    raise exceptions.ValidationError(f'The offer must be higher than {current_property.best_offer}')


Not a problem for the tutorial, but with an actual module, we usually don't use fstrings for errors, as you cannot translate these

Here is an example of how we usually format translated strings with parameters
https://github.com/odoo/odoo/blob/fc658b2e3d9c5afbfa5d00b579bf8928a90dab87/addons/barcodes/models/barcode_rule.py#L41

antonrom1 · 2025-11-21T16:16:34Z

estate/models/estate_property_tag.py

@@ -0,0 +1,17 @@
+# Part of Odoo. See LICENSE file for full copyright and licensing details.


No need license

antonrom1 · 2025-11-21T16:17:47Z

estate/views/estate_property_views.xml

+        <field name="res_model">estate.property</field>
+        <field name="view_mode">list,form,kanban</field>
+        <field name="search_view_id" ref="estate_property_view_search"/>
+        <field name="context">{'search_default_filter_available':1}</field>


Keep the spacing consistent in XMLs too

Suggested change

<field name="context">{'search_default_filter_available':1}</field>

<field name="context">{'search_default_filter_available': 1}</field>

antonrom1 · 2025-11-21T16:18:36Z

estate_account/__manifest__.py

+    'data': [
+    ],
+    'demo': [
+    ],


Don't need to define these if no data or demo

antonrom1 · 2025-11-21T16:27:54Z

estate_account/models/estate_property.py

+
+    def action_property_sold(self):
+        invoice_vals_list = []
+        for record in self:


In super().action_property_sold you call self.ensure_one(), and here you suppose that it's an iterable. You should pick one.

tskv added 4 commits November 18, 2025 14:05

[ADD] estate:taskv

748a2b7

[ADD] estate: init

07ee005

[IMP] new model: estate_property

0db978f

[IMP] estate_property:new fields

b78f9c1

yoba-odoo requested changes Nov 19, 2025

View reviewed changes

tskv force-pushed the 19.0-tutorials-taskv branch 2 times, most recently from 1490adf to a786d01 Compare November 20, 2025 08:28

tskv added 7 commits November 20, 2025 09:30

[IMP] estate: access rights

c66d2ad

[IMP] estate: menu + view form

821328f

[IMP] estate: chapter 6 (views)

afec0e3

[IMP] estate: chapter 7 (relational fields)

b87b0a4

[IMP] estate: chapter 8 (compute and onchange)

ae44645

[IMP] estate: chapter 9 (actions)

898c085

[IMP] estate: chapter 10 (constraints)

347453f

tskv force-pushed the 19.0-tutorials-taskv branch from a786d01 to 347453f Compare November 20, 2025 08:31

[IMP] estate: chapter11 (sprinkles)

d490741

tskv force-pushed the 19.0-tutorials-taskv branch from bab10bf to d490741 Compare November 20, 2025 13:03

[IMP] estate: chapter 12 (inheritance)

220923d

tskv force-pushed the 19.0-tutorials-taskv branch from 3aa1cb8 to 220923d Compare November 20, 2025 14:36

[ADD] estate: invoicing (chapter 13)

b722b3e

tskv force-pushed the 19.0-tutorials-taskv branch from e737a99 to b722b3e Compare November 20, 2025 16:11

tskv added 2 commits November 21, 2025 10:01

[ADD] estate: kanban view (chapter 14)

64e100c

[IMP] estate: chapter 15

03cee0d

antonrom1 reviewed Nov 21, 2025

View reviewed changes

	date_availability = fields.Date('Available From', copy=False, default=fields.Datetime.now() + timedelta(days=90))
	date_availability = fields.Date('Available From', copy=False, default=fields.Date.add(fields.Date.today(), months=3)

	action="estate.estate_property_action"
	action="estate_property_action"

	action="estate.estate_property_type_action"
	action="estate_property_type_action"

	action="estate.estate_property_tag_action"
	action="estate_property_tag_action"

		# Part of Odoo. See LICENSE file for full copyright and licensing details.

		@@ -0,0 +1,17 @@
		# Part of Odoo. See LICENSE file for full copyright and licensing details.

	<field name="context">{'search_default_filter_available':1}</field>
	<field name="context">{'search_default_filter_available': 1}</field>

19.0 tutorials taskv #1035

Are you sure you want to change the base?

19.0 tutorials taskv #1035

Conversation

tskv commented Nov 18, 2025

Uh oh!

robodoo commented Nov 18, 2025

Uh oh!

yoba-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

antonrom1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants