[IMP] supplier_portal: added supplier portal #394

siha-odoo · 2025-02-25T12:27:20Z

With this commit

Introduced a new route allowing suppliers to upload invoices
in PDF and XML format.
Added a webpage with a company selection dropdown, displaying companies
linked to the user.
Successfully uploaded documents will generate a new draft vendor bill
in the backend.

robodoo · 2025-02-25T12:27:25Z

rare-odoo

Hello @siha-odoo,

I have left some change requests in the review for your consideration.

rare-odoo · 2025-02-27T05:49:33Z

supplier_portal/__manifest__.py

+    "name": "Supplier Portal",
+    "version": "1.0",
+    "author": "Harsh Siddhapara siha",
+    "depends": ["base", "account", "website"],


Do we need base here?

NO it is not needed. I will update it.

rare-odoo · 2025-02-27T05:50:56Z

supplier_portal/controllers/supplier_portal.py

+        return request.render("supplier_portal.supplier_portal_upload_template")
+
+    @http.route("/supplier/portal/submit", type="http", auth="user", website=True)
+    def supplier_portal_submit_document(self, **kwargs):


This method requires a check, as there seems to be quite a bit of redundant code.
Additionally, Could you clarify why sudo() is used here?

okay, because portal user do not have access of invoicing so in order to create vendor bill sudo() is needed,

rare-odoo · 2025-02-27T05:56:21Z

supplier_portal/views/supplier_portal_website_menu.xml

+    <record id="menu_supplier_portal" model="website.menu">
+        <field name="name">Upload Document</field>
+        <field name="url">/supplier/upload/</field>
+        <field name="parent_id" ref="website.main_menu"/>
+        <field name="sequence">10</field>
+    </record>


Without the groups, this button would be visible to all users on the website!

Will update it.

rare-odoo · 2025-02-27T05:57:20Z

supplier_portal/views/supplier_portal_template.xml

+            <div class="container mt-5">
+                <h2 class="text-center text-primary mb-4">Upload Supplier Documents</h2>
+                <form action="/supplier/portal/submit" method="post" enctype="multipart/form-data" class="shadow p-4 bg-white rounded">
+                    <input type="hidden" name="csrf_token" t-att-value="request.csrf_token()"/>


Could you explain why you used csrf_token and how its value is set here?

In a session unique csrf_token will be generated for logged in user and while uploading files it has to match the csrf_token with stored csrf_toekn so that desired upload operation can be perfomed. Session's generated token is stored in request.csrf_token() so setting attribute value inside form csrf_token will be accessed and at time of form submission both tokens will be matched.

rare-odoo · 2025-02-27T05:58:39Z

supplier_portal/views/supplier_portal_template.xml

+                    <div class="mb-3">
+                        <label class="form-label fw-bold">Upload PDF File</label>
+                        <input type="file" name="pdf_file" class="form-control" accept=".pdf"/>
+                    </div>
+                    <!-- XML Upload Field -->
+                    <div class="mb-3">
+                        <label class="form-label fw-bold">Upload XML File</label>
+                        <input type="file" name="xml_file" class="form-control" accept=".xml"/>
+                    </div>


Why are there two separate buttons? This could potentially confuse the user.
Isn't it possible to use single upload button?

Right now i am checking condition to validate both pdf and xml files are uploaded or not. I will see if i can do it with single upload or not.

rare-odoo · 2025-02-28T12:51:16Z

supplier_portal/controllers/supplier_portal.py

+                return request.render("supplier_portal.after_submit_message_template",
+                                      {"error_message": f"Invalid file type: {file_name}. Please upload only PDF or XML files."})


Could we utilize a validation error here instead of rendering a new template?

yes we can. I will change it.

rare-odoo · 2025-02-28T12:55:46Z

supplier_portal/controllers/supplier_portal.py

+        return request.render("supplier_portal.after_submit_message_template",
+                              {"success_message": f"{len(attachments)} files uploaded successfully."})
+
+


It seems there’s some indentation present here.

It still hasn’t been resolved yet, has it?

rare-odoo · 2025-03-03T06:42:41Z

supplier_portal/views/supplier_portal_template.xml

+                    </div>
+                    <!-- Upload file with .pdf or .xml extension -->
+                    <div class="mb-3">
+                        <label class="form-label fw-bold">Upload PDF File</label>


Suggested change

<label class="form-label fw-bold">Upload PDF File</label>

<label class="form-label fw-bold">Upload</label>

rare-odoo · 2025-03-03T06:45:23Z

supplier_portal/views/supplier_portal_template.xml

+                    <!-- Upload file with .pdf or .xml extension -->
+                    <div class="mb-3">
+                        <label class="form-label fw-bold">Upload PDF File</label>
+                        <input type="file" name="upload_file" class="form-control" multiple="multiple" accept=".pdf,.xml"/>


You’ve specified .pdf and .xml in the accept attribute—have you tested it with other file types,
like images or something else?

yes tried for csv file.

rare-odoo · 2025-03-03T06:46:03Z

supplier_portal/controllers/supplier_portal.py

+        return request.render("supplier_portal.after_submit_message_template",
+                              {"success_message": f"{len(attachments)} files uploaded successfully."})
+
+


It still hasn’t been resolved yet, has it?

-Introduced a new route allowing suppliers to upload invoices in PDF and XML format. -Added a webpage with a company selection dropdown, displaying companies linked to the user. -Successfully uploaded documents will generate a new draft vendor bill in the backend.

rare-odoo suggested changes Feb 27, 2025

View reviewed changes

siha-odoo force-pushed the 18.0-supplier-portal-siha branch from 4ac1950 to 30f32d7 Compare February 27, 2025 11:34

rare-odoo suggested changes Feb 28, 2025

View reviewed changes

siha-odoo force-pushed the 18.0-supplier-portal-siha branch from 30f32d7 to 669db01 Compare March 3, 2025 04:45

rare-odoo suggested changes Mar 3, 2025

View reviewed changes

siha-odoo force-pushed the 18.0-supplier-portal-siha branch from 669db01 to 2f205ac Compare March 3, 2025 09:00

siha-odoo force-pushed the 18.0-supplier-portal-siha branch from 2f205ac to e4258ab Compare March 3, 2025 09:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] supplier_portal: added supplier portal #394

[IMP] supplier_portal: added supplier portal #394

siha-odoo commented Feb 25, 2025

robodoo commented Feb 25, 2025

rare-odoo left a comment

rare-odoo Feb 27, 2025

siha-odoo Feb 27, 2025

rare-odoo Feb 27, 2025

siha-odoo Feb 27, 2025 •

edited

Loading

rare-odoo Feb 27, 2025

siha-odoo Feb 27, 2025

rare-odoo Feb 27, 2025

siha-odoo Feb 27, 2025

rare-odoo Feb 27, 2025

siha-odoo Feb 27, 2025

rare-odoo Feb 28, 2025

siha-odoo Mar 3, 2025

rare-odoo Feb 28, 2025

siha-odoo Mar 3, 2025

rare-odoo Mar 3, 2025

rare-odoo Mar 3, 2025

siha-odoo Mar 3, 2025

rare-odoo Mar 3, 2025

siha-odoo Mar 3, 2025

rare-odoo Mar 3, 2025

		return request.render("supplier_portal.after_submit_message_template",
		{"error_message": f"Invalid file type: {file_name}. Please upload only PDF or XML files."})

		return request.render("supplier_portal.after_submit_message_template",
		{"success_message": f"{len(attachments)} files uploaded successfully."})

	<label class="form-label fw-bold">Upload PDF File</label>
	<label class="form-label fw-bold">Upload</label>

[IMP] supplier_portal: added supplier portal #394

Are you sure you want to change the base?

[IMP] supplier_portal: added supplier portal #394

Conversation

siha-odoo commented Feb 25, 2025

With this commit

robodoo commented Feb 25, 2025

rare-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

siha-odoo Feb 27, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

siha-odoo Feb 27, 2025 •

edited

Loading