[IMP] rental_deposit: added deposit in rental #422
+212
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added deposit product in config settings by inheriting res_config_settings model added require deposit and deposit amount in product template by inhering product_template model added inherited view for template as well as config settings also inherited view for product template task - 4605761
|
|
- Deposit will be added in sale order line when any product is selected in which deposit is configured - Also added write override, if product or quantity is changed then it reflects to deposit also - Added unlink override if product which has deposit and removed it from sale order line then remove deposit also - In website module on rental product, required deposit will be displayed task - 4605761
- Ensured that only one deposit added when duplicating sale order - Controller added to track qty from website. - improved sale order line creation logic task - 4605761
- Ensured that on duplicating more than one sale order ensure that it works perfectly - Onchange method is defined in product_template task - 4605761
bhra-odoo
suggested changes
Mar 5, 2025
| @api.onchange('require_deposit') | ||
| def _onchange_require_deposit(self): | ||
| self.write({ | ||
| 'deposit_amount': 0 if self.require_deposit else 0 |
There was a problem hiding this comment.
This is not needed
I was checking that if someone after setting a deposit untick then retick on that time it should be zero.
But it i forgot to remove it
so i will remove it
| vals_list = super().copy_data(default=default) | ||
| for order, vals in zip(self, vals_list): | ||
| vals['order_line'] = [ | ||
| Command.create(line) |
There was a problem hiding this comment.
below line 19, in for loop
Command.create(line)
for line in order._get_copiable_order_lines_without_deposit().copy_data()
- Removed onchange_require_deposit as not needed - Instead of direct creating deposit line used list to create it - Extended controller class to get qty in website - Extended Widget to display deposit which change based on required quantity
bhra-odoo
suggested changes
Mar 20, 2025
- sudo() removed as without bypassing access rights we can get deposit product
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
product_template model
deposit is configured
to deposit also
order line then remove deposit also
task - 4605761