18.0 onboarding owl hasaa #974
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@hasaa-odoo Your PR is from a branch in 18.0 to 19.0, make sure the diff on the pr consists only of your changes |
cgun-odoo
reviewed
Sep 25, 2025
There was a problem hiding this comment.
don't push anything inside .vscode 💢
| openLeads() { | ||
| this.action.doAction({ | ||
| type: 'ir.actions.act_window', | ||
| name: 'CRM Leads', |
There was a problem hiding this comment.
You can make the name translatable
Also check where the name shows up when you run the action. It's important to know
cgun-odoo
reviewed
Sep 26, 2025
cgun-odoo
reviewed
Sep 26, 2025
awesome_dashboard/static/src/dashboard/piechartcard/pirchart_card.xml
Outdated
Show resolved
Hide resolved
awesome_dashboard/static/src/dashboard/piechartcard/pirchart_card.js
Outdated
Show resolved
Hide resolved
awesome_dashboard/static/src/dashboard/piechartcard/pirchart_card.xml
Outdated
Show resolved
Hide resolved
Comment on lines
15
to
17
| get Width() { | ||
| return 18*this.props.size | ||
| } |
There was a problem hiding this comment.
you should maybe name it something like itemWidth
cgun-odoo
reviewed
Sep 29, 2025
awesome_dashboard/static/src/dashboard/numbercard/number_card.xml
Outdated
Show resolved
Hide resolved
awesome_dashboard/static/src/dashboard/config_dialog/config_dialog.js
Outdated
Show resolved
Hide resolved
awesome_dashboard/static/src/dashboard/config_dialog/config_dialog.js
Outdated
Show resolved
Hide resolved
hasaa-odoo
force-pushed
the
18.0-onboarding-owl-hasaa
branch
from
95411aa to
bce32b6
Compare
hasaa-odoo
force-pushed
the
18.0-onboarding-owl-hasaa
branch
from
11e66f7 to
3a7ac6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for the web framework tutorial,
Note , i forgot to commit the changes for the old section so this will be my first commit (starting from 8th section)