Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.38 #170

Merged
merged 5 commits into from
Feb 21, 2025
Merged

7.38 #170

merged 5 commits into from
Feb 21, 2025

Conversation

Geczy
Copy link
Contributor

@Geczy Geczy commented Feb 19, 2025

No description provided.

@Geczy Geczy changed the title chore: npm run prettier 7.38 Feb 19, 2025
@builder-247
Copy link
Member

This appears to remove the dname attribute from neutral items

@Geczy
Copy link
Contributor Author

Geczy commented Feb 20, 2025

This appears to remove the dname attribute from neutral items

Can you fix it?

@builder-247
Copy link
Member

This appears to remove the dname attribute from neutral items

Can you fix it?

Try changing line 222 to

item.dname = strings[`DOTA_Tooltip_ability_${key}`] || strings[`DOTA_Tooltip_ability_${key}:n`];

@Geczy
Copy link
Contributor Author

Geczy commented Feb 20, 2025

That helped, thanks! It seemed to break just a few of these tho:

"dname": "+{s:bonus_arrow_bonus_damage} Sacred Arrow Bonus Damage"

@howardchung howardchung merged commit ddff4a5 into odota:master Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardchung howardchung howardchung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Geczy @builder-247 @howardchung