Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old newton function and use newton_with_kwargs instead #484

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

fwitte
Copy link
Member

@fwitte fwitte commented Jan 29, 2024

The convergence critereon for the newon helper algorithms needed to be updated to target values equal to zero. In case the target value is zero, the tolerance mode is set to absolute difference now. On top of that the old newton function was removed and now all parts of the code use the newton_with_kwargs function.

@pep8speaks
Copy link

pep8speaks commented Jan 29, 2024

Hello @fwitte! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 474:80: E501 line too long (90 > 79 characters)
Line 505:80: E501 line too long (90 > 79 characters)

Line 41:80: E501 line too long (82 > 79 characters)
Line 46:80: E501 line too long (84 > 79 characters)
Line 51:80: E501 line too long (82 > 79 characters)
Line 57:80: E501 line too long (85 > 79 characters)

Comment last updated at 2024-01-29 18:55:22 UTC

@fwitte fwitte merged commit 3fddc8d into dev Jan 29, 2024
8 of 9 checks passed
@fwitte fwitte deleted the fix/newton-convergence-critereons branch October 27, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants