feat: add extra sql functions #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add postgres built-in timezone function
Add postgres EXISTS(...subquery...) function. This is required by typeorm exists method. See: https://github.com/typeorm/typeorm/blob/e7649d2746f907ff36b1efb600402dedd5f5a499/src/query-builder/QueryBuilder.ts#L1273
This function is required by typeorm to inspect the entity comments. See: https://github.com/typeorm/typeorm/blob/e7649d2746f907ff36b1efb600402dedd5f5a499/src/driver/postgres/PostgresQueryRunner.ts#L3291
oguimbal
approved these changes
Oct 11, 2024
|
Thanks ! You can however declare this function outside of pg-mem though custom functions, though Other changes are released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I've been using pg-mem with TypeOrm and there are some functions required by TypeOrm which pg-mem does not implement:
existsandobj_description, I've implemented them on my project withregisterFunctionbut since they are required by the ORM and there's an adapter for it I though it would be nice to upstream it so that others don't have to implement them.I've also included the built-in
timezonefunction, which is not required by the ORM but I was also using it on my project.I've included the moment-timezone package as the project already included the moment package, if you are against it let me know and I can remove it.
What this pull request does
existsfunctionobj_descriptionfunction (I'm simply returningnull, with the reason being that the comments won't affect the database, if you disagree I can implement the full functionality of storing/updating/removing comments)timezonefunction (includes themoment-timezonepackage to assist with timezone manipulation)