Add inverter base class and related interfaces #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onius inverter interfaces with unit tests - Created `inverter_factory.py` to manage inverter instantiation based on configuration. - Introduced `NullInverter` class for display-only mode and EVCC integration, implementing no-op methods. - Developed `VictronInverter` class as a stub for future Modbus/TCP integration. - Added `FroniusLegacy` and `FroniusV2` classes with comprehensive unit tests covering initialization, capabilities, and API interactions. - Implemented unit tests for `NullInverter`, `VictronInverter`, and `Fronius` inverters to ensure compliance with expected behaviors. - Established test fixtures for consistent configuration across tests.
Owner
|
@Awienert needed a longer journey ... ;-) - was a lot broken ... But I followed your approach, but restructered a little... So please finalize your specific integrations for victron src/interfaces/inverters/victron.py And if done and tested we can go to develop branch. |
Author
|
@ohAnd Sorry for the broken parts — my environment was working 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft – Proposal for New Inverter Architecture
This PR is a draft and a proposal introducing a new inverter architecture.
What's new
BaseInverter: shared abstract base class providing a unified interface and reducing duplicate logic.
InverterFactory: creates inverter instances based on config, making it easier to add new inverter types.
Why
cleaner structure
easier extensibility
consistent API for all inverters