Support fhir_id column in hfj_resource for HAPI 7.2.0+#1602
Open
trifork-alialkindi wants to merge 1 commit into
Open
Support fhir_id column in hfj_resource for HAPI 7.2.0+#1602trifork-alialkindi wants to merge 1 commit into
trifork-alialkindi wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
This implements issue #1219
by adding support for the
fhir_idcolumn onhfj_resourcetable to support the newer versions 7.2.0+ of HAPI FHIR Server.E2E test
TESTED:
Started a HAPI server + PostgreSQL
Waited for HAPI server and the PostgreSQL to be ready.
Then created a sink DB.
Created temporary config files.
Then populated the HAPI Server with test resources.
Ran the pipeline
java -cp pipelines/batch/target/batch-bundled*.jar \ com.google.fhir.analytics.FhirEtl \ --fhirFetchMode=HAPI_JDBC \ --resourceList=Patient \ --fhirDatabaseConfigPath=/tmp/hapi-postgres-config-local.json \ --sinkDbConfigPath=/tmp/sink-db-config-local.jsonVerified correct resource id in sink DB.
Found:
my-patient-abcandmy-patient-xyz(not numeric IDs). ✅Cleaned up then repeated the test with
hapiproject/hapi:v7.0.0image instead of latest to validate backward compatibality.Checklist: I completed these to help reviewers :)
I have read and will follow the
review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review
Java and
Python style guides.
My IDE is configured to follow the Google
code styles.
No? Unsure? ->
configure your IDE.
I have added tests to cover my changes. (If you refactored existing
code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
If I made any Python code changes, I ran
black .,pylint .andpyright. right before creating this pull request and added allformatting changes to my commit.
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master