Fixed dead characters respawning at the site would retain inventory items

[yahvk-cuna]

When respawn is on, dead characters who respawn at the site will retain inventory items, causing the character's inventory to be copied.

[Akronyhm]

Does this properly fix the problem? By looking into the documentation it appears like StartItemsGiven is more or less a flag that is set whenever a character has properly spawned in; and is retained in the xml.

I would feel abit more secure if inventory-/ and hpData were null-checked before assigned (or at the very least set to some default) to the character (which is mainly what the original code-block was attempting to do)

The proper fix might be to grab a default-spawn item-package and assign it if the loaded inventory and hp information are null

[yahvk-cuna]

Sorry that I forgot about this PR.

In

multiplayer-crew-manager/CSharp/Server/McmSave.cs

Line 296 in fb35b06

charInfo.StartItemsGiven = false;

, it flags dead people with StartItemsGiven false, so the if condition is met when the character is respawning. Setting the inventory to null and StartItemsGiven to false is the correct way to indicate this character is respawning and will lead the game to give job items in https://github.com/FakeFishGames/Barotrauma/blob/47badaf760c216d5bb807fd26de87b7e284683bb/Barotrauma/BarotraumaShared/SharedSource/GameSession/CrewManager.cs#L291-L301.

I have been running my campaigns with this change. I haven't had any problems related to this in the past few months.