Fix the Num instance of Frac #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`abs x * signum x` is supposed to be the same as `x`. Make this the case, as well as making `abs` work as you'd expect for fractions in math.
Author
|
Wait a minute, the rest of the instance doesn't work either... There is no |
Turn `Natural`s into `Integer`s before trying to multiply them by other `Integer`s, and don't call a non-existent `numerator` function.
josephcsible
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abs x * signum xis supposed to be the same asx. Make this the case, as well as makingabswork as you'd expect for fractions in math.Turn
Naturals intoIntegers before trying to multiply them by otherIntegers, and don't call a non-existentnumeratorfunction.