Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python interface for calling the C++ code #14

Open
wants to merge 190 commits into
base: master
Choose a base branch
from

Conversation

misharash
Copy link
Collaborator

@misharash misharash commented Nov 29, 2023

Defining change: python function wrapper that launches the main computation.
Currently realized by writing the temporary files and invoking the appropriate pre-built binary on command line automatically for the user.
Worth a major version (3.0) in my opinion.

Also restructured most of the scripts, in each one wrapped the full procedure as well as its reusable parts into functions.

TODO:

  • test;
  • update the docs,
    • rewrite the tutorials into Jupyter notebooks;
  • form an installable Python package;

and other minor fixes
Hopefully they are clearer now
Also changed the logic a bit in ordinary jackknife
Centralized c2 diagonalization
Combined two loading functions to one
misharash added 30 commits July 15, 2024 18:35
Should prevent all pycorr errors about position arrays not being of the same data type
Switched to pyproject.toml with hatchling
Potentially problematic with fast math
About unusually small separation between randoms of two different types
Should be no more than 1 warning per loop per integral
Taking into account possibility of shot-noise rescaling <1
They are not important unless the adjustment procedure fails repeatedly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant