-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added oAuth2 to security interface #33
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi can you pls create this pull request under my fork swagger-express-ts2? I am maintaining it.
…of the property definition, which is wrong for swagger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name of your pull request is not corresponding with the changes you made
@@ -21,7 +21,7 @@ | |||
"type": "git", | |||
"url": "git+https://github.com/olivierlsc/swagger-specification-ts.git" | |||
}, | |||
"author": "Olivier LIN-SI-CHENG", | |||
"author": "Alexander Bauer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relax, you can override that. It is just for local assignment in our team, so ppl know whom to talk to internally. Also this was originally not part of the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, did you look at the fork i already made? I fixed many things and i have prepared 2.0.0 in progress which will completely cover whole functionality swagger 2. After that i will continue to support of openapi 3 functionalities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relax, you can override that. It is just for local assignment in our team, so ppl know whom to talk to internally. Also this was originally not part of the PR.
But why do you then out it into the PR?
@@ -21,7 +21,7 @@ | |||
"type": "git", | |||
"url": "git+https://github.com/olivierlsc/swagger-specification-ts.git" | |||
}, | |||
"author": "Olivier LIN-SI-CHENG", | |||
"author": "Alexander Bauer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relax, you can override that. It is just for local assignment in our team, so ppl know whom to talk to internally. Also this was originally not part of the PR.
But why do you then out it into the PR?
No description provided.