Skip to content

Conversation

@will-moore
Copy link
Member

@will-moore will-moore commented Jun 24, 2025

This commit is from #174 (being tested there by Jason) but is picked to a separate PR so we can merge and release...

If masks have theC set (and there is more than 1 value for theC) then we export a multi-channel mask image (don't squeeze out the C dimension).

cc @jburel

This bug was introduced in 101b0e1, released in v0.6.0 (June 2024)

To test, create or find an Image with Polygons that have different values for theC. E.g. on merge-ci Image:23117:

Screenshot 2025-08-18 at 14 52 07

Export the image, then export polygons to labels, using --overlaps=dtype_max because some Shapes with the same C value are overlapping:

$ omero zarr export Image:23117
$ omero zarr polygons Image:23117 --overlaps=dtype_max

Now view with:

$ ome_zarr view 23117.ome.zarr/

Click on labels/0 link to view the labels in validator, then click the vizarr icon to view labels in vizarr.
You should see that this is a multichannel image, with labels on different channels.
By default, vizarr will scale rendering so that the brightest label (e.g. value 1 or value 2) is saturated. For any overlapping labels, the overlap is assigned to max, e.g. 127, so the other labels (e.g. value 1 or value 2) will be almost black, unless you boost the levels:

Screenshot 2025-08-18 at 14 58 31

Without this PR, all the labels are exported to a single channel:

Screenshot 2025-08-18 at 15 06 01

@snoopycrimecop
Copy link
Member

snoopycrimecop commented Aug 27, 2025

Conflicting PR. Removed from build OMERO-plugins-push#516. See the console output for more details.
Possible conflicts:

--conflicts Conflict resolved in build OMERO-plugins-push#517. See the console output for more details.

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-plugins-push#535. See the console output for more details.
Possible conflicts:

  • Upstream changes
    • CHANGELOG.md

--conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants