-
Notifications
You must be signed in to change notification settings - Fork 38
externalInfo display #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
externalInfo display #613
Conversation
sbesson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@will-moore thanks for starting this conversation. As noted above, Glencoe is using ExternalInfo quite extensively so we are interested in ways to expose this metadata via the OMERO.web API and/or UI.
Starting with with your last question, my immediate feeling is that it would be most beneficial to include this functionality in the OMERO.web JSON API. A few reasons for that:
- as explained in https://omero.readthedocs.io/en/stable/developers/Web.html, the
/webclientcomponent should be considered as internal only. If the intent is to expose this metadata as JSON for consumption (both internal and external),api/is the location of choice omero-marshalalready has support forExternalInfoencoding/decoding so there is no complex cross-component work- the usage of
ExternalInfois not limited toImageand can be applied to any object. Glencoe uses this onMaskobjects to represent labels for instance. Havingapi/v0/<images,rois,...>/<id>loading and exposing the external info in a unified manner would be consistent.
On the query itself, my impression is that externalInfo should be treated the same way as other details. I don't expect the additional join to be expensive in terms of query time given these are relatively shallow objects with only a few attributes but that should certainly be reviewed as par of the functional testing.
The UI questions is probably the one where I am the less opinionated and I have a suspicion the answer might be "it depends". For Zarr data, we have used ExternalInfo as an mechanism to store the location of the data. The closest equivalent would be the legacy OMERO pyramids which are not exposed in the UI. The most relevant existing icon would be the ../../. in the right-hand panel which lists the Fileset entries.
However other ExternalInfo objects might be more naturally suited either as Image details or as additional attributes
|
Agree with @sbesson; I would probably not create a separate view for retrieving |
ff2eab8 to
cac3aa7
Compare
|
@sbesson This is now deployed on idr-testing. e.g. https://idr-testing.openmicroscopy.org/webclient/?show=image-15160031 |
|
As a quick sidenote before I disappear for a week, I'd be more than happy if we hide the acronym "LSID" from users. |
|
👍 Looks good to me. What does LSID actually stand for, and what is the ExternalInfo actually used for generally @joshmoore ? |
|
LSID stands for "Life Science Identifier". https://www.lsid.info/ et al. https://zenodo.org/records/46804 is a pretty good read. The ExternalInfo object wasn't used a lot previously but was intended to hold info of the objects that felt "too detailed" to expose in the main object. It also helps that if you have an opaque identifier that you don't have to check every table to find the object but you can look in the one external info table. |
|
https://en.wikipedia.org/wiki/LSID. Do we use another term or just e.g. |
"Attribues"? "Attachments"? 😄
I certainly worry about CLI users less. But if we need to keep it, that's fine, just more than the other terms, "LSID" was a mistake. |
|
As discussed in web meeting, we probably don't want |
|
Deployed latest changes to idr-testing and updated screenshot above. |
|
To help testing, you can now set ExternalInfo via the CLI - see ome/omero-py#453 |
|
In IDR (and regular OMERO if/when omero-zarr-pixel-buffer becomes adopted) we want it to be nice and easy for a user to get the OME-Zarr URL for an image they are looking at, as they can do for e.g. https://idr.github.io/ome-ngff-samples/. We probably don't want to show "External Info" or |
|
As discussed in web meeting today:
|
|
As discussed with @jburel... Since we have addressed s3 backend issues in omero-zarr-pixel-buffer, we can expect to use genuine public URLs for external-info, so this should be easier for the user to find. This also gives us the chance to add "Open with" various zarr viewers. |
|
Note that everything that is discussed is conditional to the fact the
Not sure I understand. Unlike the
At least, this should be correct for Amazon S3. The service supports to types of requests: Path-style requests and Virtual-hosted–style requests. So
If the intent is to create an HTTP URL using by any a third-party application, then such transformation is probably only applicable to public data. No query parameter in a S3 |
|
@will-moore we cannot change the value to https or remove anonymous as @sbesson indicated. We only discussed showing external info to help identifying the "registered" one not reformatting it. to use it in the web, the application will need to parse it |
|
I understand that omero-web will need to parse it - I'm just asking if it will always work to replace |
Definitely not in the general case. |
|
To be discussed at next web meeting... |
| {% endif %} | ||
|
|
||
| <!-- External Info (Zarr url)--> | ||
| {% with extinfo=obj.getExternalInfo %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: with ome/omero-py#483 this should now be obj.getDetails().getExternalInfo()
| <!-- This is HIDDEN here, but cloned into the Fileset Info panel when shown --> | ||
| <div id="externalInfo" class="debug" style="display: none; margin-top: 20px; font-size: 13px;"> | ||
| <!-- This will return None if obj.getExternalInfo method doesn't exist (omero-py 5.19.6 and earlier) --> | ||
| {% with extinfo=obj.getExternalInfo %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: with ome/omero-py#483 this should now be obj.getDetails().getExternalInfo()
Since we are starting to use externalInfo in IDR and possibly for other users - see https://github.com/ome/omero-cli-zarr/pull/167/files, it may be useful to display this in web. Glencoe already use this.
Updated description based on discussions below:
We don't show anything new by default since ExternalInfo is considered to be "debug" info only.
You can show it by using the browser dev Console to show elements with debug class with:
$(".debug").show()We aim to load externalInfo along with the original objects (instead of an extra lazy loading call)
getObject() and getExternalInfo() load externalInfo omero-py#453 updates
getObject()etc to include externalInfoWe use that PR to display in the right panel (nothing is shown if
externalInfois not found)NB: if the omero-py PR is missing, then this will fail silently since
obj.getExternalInfowill not be found. No need for this PR to depend on getObject() and getExternalInfo() load externalInfo omero-py#453cc @knabar @dominikl