Skip to content

Pvp image display#564

Draft
pld wants to merge 9 commits into
mainfrom
pvp-image-display
Draft

Pvp image display#564
pld wants to merge 9 commits into
mainfrom
pvp-image-display

Conversation

@pld

@pld pld commented Jul 21, 2026

Copy link
Copy Markdown
Member

Display PVP bundle images on the form screens (data entry, QC, corrections, audit). Adds a unified ResultFormImage model with Pillow verify-before-store (JPEG/PNG/WebP) at the parser boundary, with size and decompression-bomb caps; corrupt or missing images are surfaced on the confirmation screen for operator consent rather than silently dropped. Images serve through an auth- and tally-scoped view with an explicit content type plus X-Content-Type-Options: nosniff. Reset soft-deletes (deactivates) PVP images for the audit trail; display, the serve view, and the number_of_images export column all honor active. Single migration; PvpSubmission drops its image fields. Manual upload lands in v2.

@codecov-commenter

codecov-commenter commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.74214% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.85%. Comparing base (acbe4f4) to head (e05ed2a).

Files with missing lines Patch % Lines
tally_ho/libs/pvp/import_submission.py 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
+ Coverage   84.68%   84.85%   +0.17%     
==========================================
  Files         174      180       +6     
  Lines       11979    12121     +142     
==========================================
+ Hits        10144    10285     +141     
- Misses       1835     1836       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pld
pld force-pushed the pvp-image-display branch from b0e43f3 to b2639b9 Compare July 21, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants