New layout, added Material design, and shortcuts#254
New layout, added Material design, and shortcuts#254lt-mayonesa wants to merge 16 commits intoondras:masterfrom
Conversation
Merge origin/master Conflicts: README.md backend/asp-file/Default.aspx backend/asp-file/Default.aspx.cs backend/cf-mysql/index.cfm backend/perl-file/index.pl backend/php-cubrid/cubrid_mysql_compat.php backend/php-cubrid/index.php backend/php-file/index.php backend/php-mysql+file/index.php backend/php-mysql+file/mysql_import.php backend/php-mysql/index.php backend/php-pdo/LayerMYSQL.php backend/php-pdo/LayerPGSQL.php backend/php-pdo/index.php backend/php-postgresql/index.php db/cubrid/datatypes.xml db/cubrid/output.xsl db/mssql/output.xsl db/mysql/datatypes.xml db/mysql/output.xsl db/oracle/datatypes.xml db/oracle/output.xsl db/postgresql/output.xsl db/sqlalchemy/datatypes.xml db/sqlalchemy/output.xsl db/sqlite/output.xsl db/vfp9/datatypes.xml db/vfp9/output.xsl dropbox-oauth-receiver.html index.html js/config.js js/globals.js js/io.js js/keymanager.js js/map.js js/options.js js/oz.js js/relation.js js/row.js js/rowmanager.js js/rubberband.js js/table.js js/tablemanager.js js/toggle.js js/window.js js/wwwsqldesigner.js locale/cs.xml locale/de.xml locale/el.xml locale/en.xml locale/eo.xml locale/es.xml locale/fr.xml locale/hu.xml locale/it.xml locale/ja.xml locale/nl.xml locale/pl.xml locale/pt_BR.xml locale/ro.xml locale/sv.xml locale/zh.xml styles/style.css
lt-mayonesa
changed the title
|
Wow, this looks huge 👍 I am extremely busy these days, so please give me some time so I can thoroughly review this PR and decide whether this redesign is consistent with my intentions of maintaining the app. If I do not reply within say 1-2 weeks, feel free to ping me again ;-) |
|
@ondras I'm taking the liberty of pinging you again :) This one looks nice. |
Thanks! I am now on a vacation. Will be returning back to civilization at 27.8., so after that I will try to find some time to merge this. |
|
Can we have this as a selectable style? I think I prefer the simplicity of the original UI |
This sounds like a very reasonable request. Ideally, the styling should happen via CSS switching (only). |
|
So, I just skimmed through the diff. It is huge and we will have to split the changeset in order to merge it meaningfully. I suggest doing this in the following manner:
The first point might be doable simply by opening the current codebase in your editor, re-saving (re-formatting) every file and commiting into a new branch. If this works, you can then merge this re-formatted branch into your redesign, reducing the size of your current PR. |
|
Hey, sorry i couldn't answer sooner. Soo, i didn't really code this re-design with "polite" merging in mind (or merging for that matter) :/ so i don't know if points 2 and 3 will be that straightforward. About the formatting, if i roll back to your formatting, wouldn't that be easier? am i missing a reason why not to? |
|
hello no news from this PR ? |
Yeah, no news, unfortunately. The PR is simply too large and destructive with respect to current codebase, so merging it seems to be a one-way transition with no means of going back (for example: people who, for some reason, might prefer the old way). If you absolutely need the functionality/design provided in the PR, feel free to fork this project and apply relevant changesets to your repo. |
|
No need "absolutely" but a new look and feel (but with backward compatibility) is a good think :) |
Added option for rubberband strategy
|
Any news on this? |
|
Yes :-) |
6 participants
Following #252 impulse i submit thee
Changes appearing in diff for following directories were made when i merged upstream, i did not modify them:
Features
Changes
Hope you like it 😄