fix logger when enabled thru ctl #1503
Open
+115
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lplewa
force-pushed
the
ctl_logger2
branch
2 times, most recently
from
173ce1a to
84d93d8
Compare
test/ctl/ctl_env_app.cpp
Outdated
| << buf << "'" << std::endl; | ||
| return 1; | ||
| } | ||
| int level = 0; |
There was a problem hiding this comment.
move int to the top of the file, I guess
test/ctl/ctl_env_app.cpp
Outdated
| char buf[256] = {0}; | ||
|
|
||
| if (argc != 2) { | ||
| std::cerr << "expected even number of arguments" << std::endl; |
| return UMF_RESULT_SUCCESS; | ||
| } | ||
| if (size < strlen(loggerConfig.file_name)) { | ||
| LOG_ERR("Invalid output argument size: %zu, expected at least %zu", |
There was a problem hiding this comment.
output or file_name?
There was a problem hiding this comment.
user asked for umf.logger.output so output
| @@ -198,11 +198,13 @@ static void *ctl_parse_args(const struct ctl_argument *arg_proto, char *arg) { | |||
| * structure as required by the node callback | |||
There was a problem hiding this comment.
can you please write at least one line of description in the commit msg, why this fix?
Logger configuration failed when set via the CTL env variable because the API used const char ** while the env var provided const char *. This mismatch affected the size field (sizeof(char *)==8 vs. string length). The API now accepts char * instead of char **.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logger configuration failed when set via the CTL env variable because
the API used const char ** while the env var provided const
char *. This mismatch affected the size field (sizeof(char *)==8
vs. string length).
The API now accepts char * instead of char **.