The last CTL patch :) #1524

lplewa · 2025-09-17T16:48:43Z

No description provided.

Split between initialize and post-initialize function is necessary for properly handling CTL defaults.

lukaszstolarczuk

after all, this is super huge PR - I'd split this somehow, if easily done...

lukaszstolarczuk · 2025-09-19T08:58:15Z

.github/workflows/reusable_compatibility.yml

@@ -228,10 +236,12 @@ jobs:
      env:
        UMF_LOG: level:warning;flush:debug;output:stderr;pid:no
      run: |
+        $env:UMF_LOG="level:warning;flush:debug;output:stderr;pid:no"


not sure if needed - we set this literally 2 lines above

lukaszstolarczuk · 2025-09-19T09:05:25Z

examples/ctl/ctl_example.c

I'd say _example in the name seems redundant and inconsistent with other examples.

// same with the other example's name

lukaszstolarczuk · 2025-09-19T09:07:21Z

examples/README.md

+
+This example demonstrates how to add CTL support to a custom memory
+provider. It sets variables ``a`` and ``b`` through CTL, plus it allows
+for the modulus ``m`` loaded from the environment or a configuration file.


to be loaded

lukaszstolarczuk · 2025-09-19T09:07:51Z

examples/README.md

+for the modulus ``m`` loaded from the environment or a configuration file.
+Addition and subtraction operations return results modulo ``m`` and the
+result ``c`` can be retrieved using the CTL API. For example, to set the
+modulus through an environment variable run::


:: -> : (this is MD file, not rst)

lukaszstolarczuk · 2025-09-19T09:09:25Z

examples/README.md

@@ -66,3 +66,14 @@ processes: a producer and a consumer that communicate in the following way
 - Producer puts the IPC handle
 - Consumer shuts down
 - Producer shuts down
+
+## CTL example
+


this description is only about one of the examples

lukaszstolarczuk · 2025-09-19T09:55:58Z

include/umf/memory_provider_ops.h

@@ -126,7 +126,7 @@ typedef struct umf_memory_provider_ops_t {
    /// \details
    /// * Implementations *must* return a literal null-terminated string.
    ///
-    /// * Implementations *must* return default pool name when NULL is provided,
+    /// * Implementations *must* return default provider name when NULL is provided,
    ///   otherwise the pool's name is returned.


since you fix above, fix here as well pool's -> provider's

test/ctl/ctl_env_disjoint_pool.cfg

lukaszstolarczuk · 2025-09-19T10:33:21Z

docs/config/examples.rst

@@ -147,6 +147,35 @@ in the UMF repository.

 TODO

+CTL statistics example


hmm and here you have the other example explained...? perhaps describe both of them in both places...? (web docs and example's README)

lukaszstolarczuk · 2025-09-19T10:33:40Z

docs/config/examples.rst

@@ -147,6 +147,35 @@ in the UMF repository.

 TODO

+CTL statistics example
+==============================================================================
+


pls mentione similarly to above examples - ... rely on experimental APIs that may change in future releases.

lukaszstolarczuk · 2025-09-19T10:33:57Z

docs/config/ctl.rst

+================
+Introduction
+================
+


pls mention experimental API

defaults changes global state, so using forks will isolate tests

lplewa changed the title ~~Ctl split~~ The last CTL patch :) Sep 17, 2025

lplewa force-pushed the ctl_split branch 11 times, most recently from 629b379 to 2706166 Compare September 18, 2025 14:44

lplewa and others added 5 commits September 18, 2025 16:53

add defaults to providers

c12dcb1

add post-initialize function to pools and providers

8208bf9

Split between initialize and post-initialize function is necessary for properly handling CTL defaults.

Initial documentation

f602262

add new error to indicate unknown/unsuported path in ctl

1bdfdf0

add params override for disjointpool

68991d4

lplewa force-pushed the ctl_split branch from 2706166 to 9e465ec Compare September 18, 2025 15:04

lplewa marked this pull request as ready for review September 18, 2025 15:22

lplewa requested a review from a team as a code owner September 18, 2025 15:22

lukaszstolarczuk requested changes Sep 19, 2025

View reviewed changes

lplewa added 5 commits September 19, 2025 15:45

use fork for default tests

f8cc704

defaults changes global state, so using forks will isolate tests

rename name to path in ctl

55d4f0a

remove tests for changing pool name thru ctl

db6df68

use actual pool name instead of default name

eff4dbd

Documentation improvements

15e7433

lplewa force-pushed the ctl_split branch from 3b5e16b to 94517a8 Compare September 19, 2025 13:45

rename examples and mark ctl as experimental in those

decb1fd

lplewa force-pushed the ctl_split branch from 94517a8 to decb1fd Compare September 19, 2025 14:44

		@@ -147,6 +147,35 @@ in the UMF repository.

		TODO

		CTL statistics example

The last CTL patch :) #1524

Are you sure you want to change the base?

The last CTL patch :) #1524

Uh oh!

Conversation

lplewa commented Sep 17, 2025 • edited by lukaszstolarczuk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukaszstolarczuk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lplewa commented Sep 17, 2025 •

edited by lukaszstolarczuk

Loading