Skip to content

Add GPU framework #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahul-179 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add GPU framework #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dkube/sdk/internal/dkube_api/models/job_status_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def state(self, state):
:param state: The state of this JobStatusModel. # noqa: E501
:type: str
"""
allowed_values = ["QUEUED", "STARTING", "TRAINING", "RUNNING", "COMPLETE", "STOPPED", "STOPPING", "DELETING", "ERROR", "IMAGEBUILDINPROGRESS", "UPDATING"] # noqa: E501
allowed_values = ["QUEUED", "STARTING", "TRAINING", "RUNNING", "COMPLETE", "STOPPED", "STOPPING", "DELETING", "ERROR", "IMAGEBUILDINPROGRESS", "UPDATING", "Waiting for 1 gpu(s)", "waiting for training to begin"] # noqa: E501
Copy link
Copy Markdown
Contributor

@deepio-oc deepio-oc Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files in internal/dkube_api are generated from gpuaas/dkube/etc/swagger yaml file. so we should not modify them manually.

We need to edit the YAML in GPUAAS repo for allowed_values to change.

Also this looks wrong, these statement should not be in the state. Number of gpus could be different.

@mak-454 How should we fix this ?
@rahul-179 can you follow up with Ahmed on this ?

if state not in allowed_values:
raise ValueError(
"Invalid value for `state` ({0}), must be one of {1}" # noqa: E501
Expand Down
6 changes: 3 additions & 3 deletions dkube/sdk/rsrcs/ide.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@

class DkubeIDE(object):

FRAMEWORK_OPTS = ["custom", "tensorflow_1.14", "tensorflow_2.0.0", "tensorflow_2.3.0",
"tensorflow_r-1.14", "tensorflow_r-2.0.0",
"pytorch_1.6", "sklearn_0.23.2"]
FRAMEWORK_OPTS = ["custom", "tensorflow_1.14", "tensorflow_1.14-gpu", "tensorflow_2.0.0", "tensorflow_2.0.0-gpu", "tensorflow_2.3.0", "tensorflow_2.3.0-gpu",
"tensorflow_r-1.14", "tensorflow_r-1.14-gpu", "tensorflow_r-2.0.0", "tensorflow_r-2.0.0-gpu",
"pytorch_1.6", "pytorch_1.6-gpu", "sklearn_0.23.2"]

def __init__(self, user, name=generate('notebook'), description='', tags=[]):
self.repo = JobInputDatumModel # class assignment, caller creates objects
Expand Down
6 changes: 3 additions & 3 deletions dkube/sdk/rsrcs/training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@

class DkubeTraining(object):

FRAMEWORK_OPTS = ["custom", "tensorflow_1.14", "tensorflow_2.0.0", "tensorflow_2.3.0",
"tensorflow_r-1.14", "tensorflow_r-2.0.0",
"pytorch_1.6", "sklearn_0.23.2"]
FRAMEWORK_OPTS = ["custom", "tensorflow_1.14", "tensorflow_1.14-gpu", "tensorflow_2.0.0", "tensorflow_2.0.0-gpu", "tensorflow_2.3.0", "tensorflow_2.3.0-gpu",
"tensorflow_r-1.14", "tensorflow_r-1.14-gpu", "tensorflow_r-2.0.0", "tensorflow_r-2.0.0-gpu",
"pytorch_1.6", "pytorch_1.6-gpu", "sklearn_0.23.2"]

DISTRIBUTION_OPTS = ["manual", "auto"]

Expand Down