Skip to content

Fix nested paths in flow cadence lint #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jribbink merged 2 commits into from
Dec 9, 2025
Merged

Fix nested paths in flow cadence lint #2213

jribbink merged 2 commits into from
Dec 9, 2025
+112 −21

Conversation

@jribbink
Copy link
Contributor

@jribbink jribbink commented Dec 2, 2025 •
edited
Loading

Closes #2214

Description

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@github-actions
Copy link

github-actions bot commented Dec 2, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 30.43478% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/util/files.go 0.00% 16 Missing ⚠️

📢 Thoughts on this report? Let us know!

@jribbink jribbink force-pushed the jribbink/cadence-lint-nest-fix branch from 9bb9def to bdd10c9 Compare December 9, 2025 00:00
@jribbink jribbink marked this pull request as ready for review December 9, 2025 03:20
@jribbink jribbink force-pushed the jribbink/cadence-lint-nest-fix branch from bdd10c9 to 7cf2677 Compare December 9, 2025 03:24
@jribbink jribbink force-pushed the jribbink/cadence-lint-nest-fix branch from 7cf2677 to f6405d9 Compare December 9, 2025 03:25
chasefleming
chasefleming reviewed Dec 9, 2025
View reviewed changes
chasefleming
chasefleming reviewed Dec 9, 2025
View reviewed changes
@jribbink jribbink merged commit b977a88 into master Dec 9, 2025
9 checks passed
@jribbink jribbink deleted the jribbink/cadence-lint-nest-fix branch December 9, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chasefleming chasefleming chasefleming approved these changes

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee Kay-Zee is a code owner

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@nvdtf nvdtf Awaiting requested review from nvdtf nvdtf is a code owner

@bjartek bjartek Awaiting requested review from bjartek bjartek is a code owner

@mfbz mfbz Awaiting requested review from mfbz mfbz is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flow cadence lint does not resolve nested String imports correctly

4 participants

@jribbink @codecov-commenter @chasefleming