Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show failure value for TCP connect on web connectivity measurement page #908

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

majakomel
Copy link
Contributor

@majakomel majakomel commented Feb 15, 2024

Closes #900

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 4:55pm

@majakomel majakomel self-assigned this Feb 15, 2024
@majakomel
Copy link
Contributor Author

@hellais @bassosimone How does this look?
https://explorer-git-issue-900-ooni1.vercel.app/m/20240215101357.076638_IR_webconnectivity_c7c9fc799e116849

Should I add check mark or similar when connection succeeds so it's clearer?

Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@majakomel majakomel merged commit 53a01fc into master Feb 15, 2024
3 checks passed
@majakomel majakomel deleted the issue/900 branch February 15, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCP Connect section of web connectivity measurement page should just state the outcome
3 participants