Replace styled-components with tailwind, upgrade ooni-components #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
majakomel
changed the title
hellais
reviewed
Aug 1, 2024
hellais
reviewed
Aug 1, 2024
|
I did a quick visual pass and left few minor comments. All in all, when those are resolve this is good to go for me. Thanks for putting this together and very glad to see this important and tedious work land 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes following changes:
<Button />component with and use utility classesbtnfor styling<Heading />component with HTML Section Heading (styled via Tailwind base)<Box />,<Flex />,<Container />,<Text />,<Link />,<Image />and style them with Tailwind utility classes instead