Skip to content

test(coverage): restore the ratchet under Coverlet 10 - #12

Merged
ooples merged 2 commits into
mainfrom
fix/coverlet10-coverage-ratchet
Sep 8, 2026
Merged

test(coverage): restore the ratchet under Coverlet 10#12
ooples merged 2 commits into
mainfrom
fix/coverlet10-coverage-ratchet

Conversation

@ooples

@ooples ooples commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Root cause

Dependabot PR #8 upgraded coverlet.collector from 6.0.4 to 10.0.1 and was merged while its coverage gate was red. The package source and test set are unchanged, but Coverlet 10 no longer falsely credits several short-circuit outcomes:

Controlled run Covered branches Branch coverage
Coverlet 6.0.4 + Test SDK 17.14.1 3111 / 4131 75.30%
Coverlet 10.0.1 + Test SDK 17.14.1 3029 / 4131 73.32%
Coverlet 6.0.4 + Test SDK 18.9.0 3111 / 4131 75.30%
Current main (Coverlet 10.0.1 + Test SDK 18.9.0) 3029 / 4131 73.32%

That isolates the change to Coverlet, not the test SDK and not product-code regression. Line coverage remained exactly 88.93% in every run.

Fix

  • retain Coverlet 10's .NET 10 support and more accurate branch semantics
  • exercise real non-finite, upper-bound, empty-archive, identity-mismatch, direction-mismatch, and retention-boundary behavior
  • keep the existing baseline and tolerance unchanged
  • do not manufacture the unreachable Completed-with-null-quality archive case; EvolutionEvaluation correctly refuses that invalid object first

Before / after proof

  • before: 275/275 tests pass, but 3029/4131 branches = 73.32%; ratchet fails at minimum 73.51%
  • after: 276/276 tests pass, 3041/4131 branches = 73.61%; ratchet passes
  • net8.0: 276/276 passed
  • net471: 276/276 passed
  • all package TFMs built with 0 warnings / 0 errors
  • package pack and eng/Test-Package.ps1: passed
  • dotnet format --verify-no-changes: passed
  • git diff --check: passed

This PR restores main's currently broken required build without reducing the coverage requirement.

Copilot AI lite review requested due to automatic review settings September 8, 2026 00:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 9c55c6fb-400c-4708-81f0-af6715c23ca5

📥 Commits

Reviewing files that changed from the base of the PR and between a924578 and cbe9a7a.

📒 Files selected for processing (6)
  • tests/AiDotNet.Evolution.Tests/UnitTests/EvolutionCoreParityTests.cs
  • tests/AiDotNet.Evolution.Tests/UnitTests/EvolutionDescriptorCalibrationTests.cs
  • tests/AiDotNet.Evolution.Tests/UnitTests/EvolutionMigrationTopologyTests.cs
  • tests/AiDotNet.Evolution.Tests/UnitTests/EvolutionPublicContractTests.cs
  • tests/AiDotNet.Evolution.Tests/UnitTests/EvolutionSelectionPolicyTests.cs
  • tests/AiDotNet.Evolution.Tests/UnitTests/MapElitesArchiveTests.cs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI review requested due to automatic review settings September 8, 2026 04:05
@ooples
ooples marked this pull request as ready for review September 8, 2026 04:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@ooples
ooples merged commit e73e4f7 into main Sep 8, 2026
10 checks passed
@ooples
ooples deleted the fix/coverlet10-coverage-ratchet branch September 8, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants