-
Notifications
You must be signed in to change notification settings - Fork 9
chore: getProof benchmark utility added #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a Go-based benchmark utility to measure the performance of the eth_getProof RPC method by testing historical proof requests against the WETH contract on Optimism. The utility is designed to support performance analysis for issue #446.
Key changes:
- Implements a concurrent benchmark tool that measures
eth_getProoflatency across configurable block ranges - Targets WETH contract with pre-defined holder addresses and calculates storage slots for balance mappings
- Reports aggregated latency statistics (avg/min/max) and error counts per block interval
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
emhane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we pls move this to a new directory op-reth-bench in
https://github.com/op-rs/op-reth/tree/unstable/bin
itschaindev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Utility for #446