feat: Add jovian specific consensus errors for jovian #551
+19
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshdfG
requested review from
dhyaniarun1993,
emhane,
itschaindev,
meyer9 and
sadiq1971
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 26 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
emhane
requested changes
Jan 8, 2026
emhane
requested changes
Jan 13, 2026
emhane
requested changes
Jan 16, 2026
Member
emhane
left a comment
emhane
left a comment
There was a problem hiding this comment.
commits need to be cherrypicked onto latest unstable
JoshdfG
force-pushed
the
op-consensus-error-for-jovian
branch
from
678a107 to
05a209c
Compare
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
JoshdfG
force-pushed
the
op-consensus-error-for-jovian
branch
from
05a209c to
3db6318
Compare
emhane
reviewed
Jan 16, 2026
Comment on lines
+126
to
+129
| return Err(OpConsensusError::Eth(ConsensusError::BlockGasUsed { | ||
| gas: GotExpected { got: cumulative_gas_used, expected: header.gas_used() }, | ||
| gas_spent_by_tx: gas_spent_by_transactions(receipts), | ||
| }) | ||
| })) |
Member
There was a problem hiding this comment.
same here nitpick, i think this works
Err(ConsensusError::BlockGasUsed { ..etc })?
Co-authored-by: Emilia Hane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #517