Skip to content

Conversation

@sadiq1971
Copy link
Collaborator

Closes #311

Performace comparison under load test:

previous: 4.873750666s
sorted delete:
3.278444083s 
sorted delete + seperate read (current as per the PR): 2.980065583s

@sadiq1971 sadiq1971 force-pushed the sadiq/optimise-prune branch from 06c1878 to 973bbf4 Compare January 9, 2026 10:02
@sadiq1971 sadiq1971 self-assigned this Jan 9, 2026
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! how did you identify this as a hot path aka worth prioritising? did you profile to get a flame graph or benchmark somehow else?

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 38.26%. Comparing base (62194ae) to head (cb5a0bf).
⚠️ Report is 3 commits behind head on unstable.

Files with missing lines Patch % Lines
crates/optimism/trie/src/db/store.rs 98.27% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/optimism/trie/src/db/store.rs 98.38% <98.27%> (+0.21%) ⬆️

... and 13 files with indirect coverage changes

Flag Coverage Δ
e2e 35.74% <93.10%> (+0.01%) ⬆️
unit 26.63% <98.27%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 53.14% <ø> (ø)
op historical proof 89.88% <98.27%> (+0.21%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sadiq1971
Copy link
Collaborator Author

nice! how did you identify this as a hot path aka worth prioritising? did you profile to get a flame graph or benchmark somehow else?

We did a breakdown and measured latency through load test using custom scrip tin unit test style.
Also based on the prev implementation it was obvious that there is some room for optimization.

@sadiq1971 sadiq1971 added this pull request to the merge queue Jan 12, 2026
Merged via the queue into unstable with commit f71945f Jan 12, 2026
50 checks passed
@sadiq1971 sadiq1971 deleted the sadiq/optimise-prune branch January 12, 2026 16:11
emhane pushed a commit that referenced this pull request Jan 13, 2026
Closes #311 

Performace comparison under load test:

```
previous: 4.873750666s
sorted delete:
3.278444083s 
sorted delete + seperate read (current as per the PR): 2.980065583s
```
emhane pushed a commit that referenced this pull request Jan 15, 2026
Closes #311 

Performace comparison under load test:

```
previous: 4.873750666s
sorted delete:
3.278444083s 
sorted delete + seperate read (current as per the PR): 2.980065583s
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize prune_earliest_state group and batch deletions by key for efficient deletion

3 participants