-
Notifications
You must be signed in to change notification settings - Fork 9
feat: optimized history deletions #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
06c1878 to
973bbf4
Compare
emhane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! how did you identify this as a hot path aka worth prioritising? did you profile to get a flame graph or benchmark somehow else?
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 13 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
We did a breakdown and measured latency through load test using custom scrip tin unit test style. |
Closes #311 Performace comparison under load test: ``` previous: 4.873750666s sorted delete: 3.278444083s sorted delete + seperate read (current as per the PR): 2.980065583s ```
Closes #311 Performace comparison under load test: ``` previous: 4.873750666s sorted delete: 3.278444083s sorted delete + seperate read (current as per the PR): 2.980065583s ```
Closes #311
Performace comparison under load test: