Skip to content

Conversation

@dhyaniarun1993
Copy link
Collaborator

Revert all the changes made as part of the hybrid storage experiment.

@dhyaniarun1993 dhyaniarun1993 self-assigned this Jan 9, 2026
@dhyaniarun1993 dhyaniarun1993 added the W-historical-proofs Workstream: historical-proofs label Jan 9, 2026
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.13%. Comparing base (01da650) to head (60b754e).
⚠️ Report is 1 commits behind head on unstable.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/optimism/exex/src/lib.rs 60.62% <ø> (-2.98%) ⬇️
crates/optimism/trie/src/api.rs 100.00% <ø> (ø)
crates/optimism/trie/src/backfill.rs 89.54% <ø> (-0.40%) ⬇️
crates/optimism/trie/src/db/store.rs 98.16% <ø> (-0.05%) ⬇️
crates/optimism/trie/src/in_memory.rs 78.14% <ø> (-0.45%) ⬇️
crates/optimism/trie/src/metrics.rs 83.58% <ø> (-1.04%) ⬇️
crates/optimism/trie/src/provider.rs 49.60% <ø> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
e2e 35.60% <ø> (-0.19%) ⬇️
unit 26.59% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 53.14% <ø> (ø)
op historical proof 89.67% <ø> (-0.30%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dhyaniarun1993 dhyaniarun1993 marked this pull request as ready for review January 9, 2026 15:59
Copilot AI review requested due to automatic review settings January 9, 2026 15:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts all changes related to a hybrid storage experiment, specifically removing the address mapping functionality that was previously added. The revert is comprehensive and affects multiple layers of the storage system.

  • Removes the store_address_mappings API method from the OpProofsStore trait
  • Eliminates address mapping storage from both in-memory and database implementations
  • Cleans up associated tests, metrics, and backfill logic

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/optimism/trie/src/provider.rs Updates Debug output test to reflect removal of address_mappings field
crates/optimism/trie/src/metrics.rs Removes StoreAddressMapping metric variant and implementation
crates/optimism/trie/src/in_memory.rs Removes address_mappings field and store_address_mappings method from in-memory storage
crates/optimism/trie/src/db/store.rs Removes store_address_mappings method and related tests from MDBX storage
crates/optimism/trie/src/db/models/mod.rs Removes AddressLookup table definition and unused Address import
crates/optimism/trie/src/backfill.rs Removes address mapping backfill logic and tests
crates/optimism/trie/src/api.rs Removes store_address_mappings method from OpProofsStore trait
crates/optimism/exex/src/lib.rs Removes calls to store_address_mappings and related imports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dhyaniarun1993 dhyaniarun1993 merged commit 62194ae into unstable Jan 12, 2026
56 of 62 checks passed
@dhyaniarun1993 dhyaniarun1993 deleted the arun/chore/revert-hybrid-storage-exp branch January 12, 2026 06:21
emhane pushed a commit that referenced this pull request Jan 13, 2026
Revert all the changes made as part of the hybrid storage experiment.
emhane pushed a commit that referenced this pull request Jan 15, 2026
Revert all the changes made as part of the hybrid storage experiment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

W-historical-proofs Workstream: historical-proofs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants