-
Notifications
You must be signed in to change notification settings - Fork 9
chore: revert hybrid storage experiment #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: revert hybrid storage experiment #568
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 9 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reverts all changes related to a hybrid storage experiment, specifically removing the address mapping functionality that was previously added. The revert is comprehensive and affects multiple layers of the storage system.
- Removes the
store_address_mappingsAPI method from theOpProofsStoretrait - Eliminates address mapping storage from both in-memory and database implementations
- Cleans up associated tests, metrics, and backfill logic
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
crates/optimism/trie/src/provider.rs |
Updates Debug output test to reflect removal of address_mappings field |
crates/optimism/trie/src/metrics.rs |
Removes StoreAddressMapping metric variant and implementation |
crates/optimism/trie/src/in_memory.rs |
Removes address_mappings field and store_address_mappings method from in-memory storage |
crates/optimism/trie/src/db/store.rs |
Removes store_address_mappings method and related tests from MDBX storage |
crates/optimism/trie/src/db/models/mod.rs |
Removes AddressLookup table definition and unused Address import |
crates/optimism/trie/src/backfill.rs |
Removes address mapping backfill logic and tests |
crates/optimism/trie/src/api.rs |
Removes store_address_mappings method from OpProofsStore trait |
crates/optimism/exex/src/lib.rs |
Removes calls to store_address_mappings and related imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Revert all the changes made as part of the hybrid storage experiment.
Revert all the changes made as part of the hybrid storage experiment.
Revert all the changes made as part of the hybrid storage experiment.