Skip to content

Conversation

@Himess
Copy link

@Himess Himess commented Jan 10, 2026

Closes #566 (1/5)

@Himess Himess marked this pull request as draft January 10, 2026 20:30
@Himess Himess changed the title refactor(trie): extract save_hashed_accounts closure to method refactor(trie): extract save_hashed_accounts closure to method1 Jan 10, 2026
@Himess Himess force-pushed the refactor/backfill-save-hashed-accounts branch from 2181a2c to 45a9c47 Compare January 10, 2026 20:36
@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.13%. Comparing base (3e4a0a1) to head (31f3175).
⚠️ Report is 1 commits behind head on unstable.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/optimism/trie/src/backfill.rs 91.07% <100.00%> (+1.53%) ⬆️

... and 11 files with indirect coverage changes

Flag Coverage Δ
e2e 35.60% <100.00%> (+0.02%) ⬆️
unit 26.60% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 53.14% <ø> (ø)
op historical proof 89.78% <100.00%> (+0.11%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Himess Himess marked this pull request as ready for review January 10, 2026 21:05
@dhyaniarun1993 dhyaniarun1993 merged commit d587e41 into op-rs:unstable Jan 12, 2026
50 checks passed
emhane pushed a commit that referenced this pull request Jan 13, 2026
Closes #566 (1/5)

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
dhyaniarun1993 added a commit that referenced this pull request Jan 13, 2026
Closes #566 (1/5)

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
emhane pushed a commit that referenced this pull request Jan 15, 2026
Closes #566 (1/5)

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
emhane pushed a commit that referenced this pull request Jan 20, 2026
Closes #566 (1/5)

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace closures in BackfillJob with functions

2 participants