Skip to content

Conversation

@Himess
Copy link

@Himess Himess commented Jan 10, 2026

Closes #566 (2/5)

@Himess Himess marked this pull request as draft January 10, 2026 20:30
@Himess Himess changed the title refactor(trie): extract save_hashed_storages closure to method refactor(trie): extract save_hashed_storages closure to method2 Jan 10, 2026
@Himess Himess force-pushed the refactor/backfill-save-hashed-storages branch from 57f1892 to 61542a3 Compare January 10, 2026 20:37
@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.26%. Comparing base (01da650) to head (61542a3).
⚠️ Report is 5 commits behind head on unstable.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/optimism/trie/src/backfill.rs 91.57% <100.00%> (+1.64%) ⬆️

... and 12 files with indirect coverage changes

Flag Coverage Δ
e2e 35.65% <100.00%> (-0.13%) ⬇️
unit 26.90% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 53.14% <ø> (ø)
op historical proof 90.07% <100.00%> (+0.10%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Himess Himess marked this pull request as ready for review January 10, 2026 21:05
Copy link
Collaborator

@dhyaniarun1993 dhyaniarun1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Himess for contribution.
Could you resolve the conflicts and add other methods to this PR?

@dhyaniarun1993
Copy link
Collaborator

superseded by #578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace closures in BackfillJob with functions

2 participants