-
Notifications
You must be signed in to change notification settings - Fork 80
Update and simplify ChatQnA tutorials #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alexsin368
commented
Apr 2, 2025
- Remove steps to build images: just use docker compose to pull images instead
- Remove outdated steps: some microservices do not need to be validated
- Add NGINX setup and validation of microservice
- Set host_ip to localhost: previously, using the external IP address causes no responses from the curl commands
- Fix grammar and improve wording
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
@lvliang-intel @letonghan could you help to review the doc PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Expected Output" and "Summary and Next Steps" sections are marked as "TBD". Ensure these sections are completed with relevant content before finalizing the document. Hope we can remove the TBD in this update. thank you!
addressed comments from @yinghu5 |
Signed-off-by: alexsin368 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- tutorial/ChatQnA/ChatQnA_Guide.rst: Language not supported
…ice validation Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
@jedwards-habana would you please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the suggested changes are grammatical and, while adding to the clarity of the document, are not critical. Otherwise the documents look good.
.
I didn't review the nvidia.md document. My suggested edit may apply to that document as well.
Signed-off-by: alexsin368 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed all of @jedwards-habana's comments to the Xeon, Gaudi, AIPC, and NVIDIA tutorials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested changes have been made. LGTM.
Signed-off-by: alexsin368 <[email protected]>