Skip to content

feat(burgers-equation): example improvements #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WojciechNeuman wants to merge 1 commit into from
Closed

feat(burgers-equation): example improvements #602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/PyMPDATA_examples/burgers_equation/burgers_equation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,20 +45,20 @@ def run_numerical_simulation(*, nt, nx, t_max):
Runs the numerical simulation and returns (states, x, dt, dx).
"""
dt, dx, x, advectee, advector, solver = initialize_simulation(nt, nx, t_max)
states = []
states = np.empty((nt, nx))
vel = advectee.get()
advector_n_1 = 0.5 * (vel[:-1] + np.diff(vel) / 2) * dt / dx
assert np.all(advector_n_1 <= 1)
i = slice(1, len(vel))

for _ in range(nt):
for n in range(nt):
vel = advectee.get()
advector_n = update_advector_n(vel, dt, dx, i)
advector.get_component(0)[1:-1] = 0.5 * (3 * advector_n - advector_n_1)
assert np.all(advector.get_component(0) <= 1)

solver.advance(n_steps=1)
advector_n_1 = advector_n.copy()
states.append(solver.advectee.get().copy())
advector_n_1 = advector_n
states[n] = solver.advectee.get()
Copy link
Member

@slayoo slayoo Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this copy() is needed, otherwise the output list will contain references to only the last timestep


return np.array(states), x, dt, dx
Loading